consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix managing widget cards for homepage

Browse Source 
The condition `params[:page_id] != 0` didn't work properly when editing
the homepage because in that case the parameter was `nil`, and the line
`SiteCustomization::Page.find(@card.site_customization_page_id)` raised
an exception because it couldn't find a page with a `nil` ID.

Fixing the issue while maintaining the check against `0` lead to complex
code, and so allowing `nil` in the database and assuming cards with no
`site_customization_page_id` belonged in the homepage seemed to be the
easiest solution.
This commit is contained in:
Javi Martín
2019-01-18 14:06:40 +01:00
committed by Manu
parent 9c050ca6bd
commit 2926e4e375
5 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spec/models/widget/card_spec.rb
View File

@@ -26,11 +26,14 @@ describe Widget::Card do
it "returns cards for the homepage body" do
header = create(:widget_card, header: true)
card1 = create(:widget_card, header: false, title: "Card 1", site_customization_page_id: 0)
card2 = create(:widget_card, header: false, title: "Card 2", site_customization_page_id: 0)
card3 = create(:widget_card, header: false, title: "Card 3", site_customization_page_id: 0)
card1 = create(:widget_card, header: false)
card2 = create(:widget_card, header: false)
page_card = create(:widget_card, header: false, page: create(:site_customization_page))
expect(Widget::Card.body).to eq([card1, card2, card3])
expect(Widget::Card.body).to include(card1)
expect(Widget::Card.body).to include(card2)
expect(Widget::Card.body).not_to include(header)
expect(Widget::Card.body).not_to include(page_card)
end
end