diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 56d9dc046..ffe4f4f4a 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -6,6 +6,7 @@ class ApplicationController < ActionController::Base include HasOrders include AccessDeniedHandler + default_form_builder ConsulFormBuilder protect_from_forgery with: :exception before_action :authenticate_http_basic, if: :http_basic_auth_site? diff --git a/app/controllers/management/base_controller.rb b/app/controllers/management/base_controller.rb index 9f45fab39..78b0f7fc3 100644 --- a/app/controllers/management/base_controller.rb +++ b/app/controllers/management/base_controller.rb @@ -1,6 +1,7 @@ class Management::BaseController < ActionController::Base include GlobalizeFallbacks layout "management" + default_form_builder ConsulFormBuilder before_action :verify_manager before_action :set_locale diff --git a/app/controllers/management/sessions_controller.rb b/app/controllers/management/sessions_controller.rb index 5617c22fb..066fc6a9f 100644 --- a/app/controllers/management/sessions_controller.rb +++ b/app/controllers/management/sessions_controller.rb @@ -3,6 +3,7 @@ require "manager_authenticator" class Management::SessionsController < ActionController::Base include GlobalizeFallbacks include AccessDeniedHandler + default_form_builder ConsulFormBuilder def create destroy_session diff --git a/app/helpers/documents_helper.rb b/app/helpers/documents_helper.rb index d8de03389..6403bd440 100644 --- a/app/helpers/documents_helper.rb +++ b/app/helpers/documents_helper.rb @@ -33,18 +33,15 @@ module DocumentsHelper def render_attachment(builder, document) klass = document.persisted? || document.cached_attachment.present? ? " hide" : "" - html = builder.label :attachment, - t("documents.form.attachment_label"), - class: "button hollow #{klass}" - html += builder.file_field :attachment, - label: false, - accept: accepted_content_types_extensions(document.documentable_type.constantize), - class: "js-document-attachment", - data: { - url: document_direct_upload_url(document), - nested_document: true - } - html + builder.file_field :attachment, + label: t("documents.form.attachment_label"), + label_options: { class: "button hollow #{klass}" }, + accept: accepted_content_types_extensions(document.documentable_type.constantize), + class: "js-document-attachment", + data: { + url: document_direct_upload_url(document), + nested_document: true + } end def document_direct_upload_url(document) diff --git a/app/helpers/images_helper.rb b/app/helpers/images_helper.rb index c865c6937..0fbe1dd2f 100644 --- a/app/helpers/images_helper.rb +++ b/app/helpers/images_helper.rb @@ -47,19 +47,15 @@ module ImagesHelper def render_image_attachment(builder, imageable, image) klass = image.persisted? || image.cached_attachment.present? ? " hide" : "" - html = builder.label :attachment, - t("images.form.attachment_label"), - class: "button hollow #{klass}" - html += builder.file_field :attachment, - label: false, - accept: imageable_accepted_content_types_extensions, - class: "js-image-attachment", - data: { - url: image_direct_upload_url(imageable), - nested_image: true - } - - html + builder.file_field :attachment, + label: t("images.form.attachment_label"), + label_options: { class: "button hollow #{klass}" }, + accept: imageable_accepted_content_types_extensions, + class: "js-image-attachment", + data: { + url: image_direct_upload_url(imageable), + nested_image: true + } end def render_image(image, version, show_caption = true) diff --git a/app/helpers/proposals_helper.rb b/app/helpers/proposals_helper.rb index ff8659dd2..1310dfc1c 100644 --- a/app/helpers/proposals_helper.rb +++ b/app/helpers/proposals_helper.rb @@ -64,10 +64,6 @@ module ProposalsHelper proposals_current_view == "default" ? "minimal" : "default" end - def summary_help_text_id(translations_form) - "summary-help-text-#{translations_form.locale}" - end - def link_to_toggle_proposal_selection(proposal) if proposal.selected? button_text = t("admin.proposals.index.selected") diff --git a/app/helpers/translatable_form_helper.rb b/app/helpers/translatable_form_helper.rb index ecd0a16a1..92eff3d33 100644 --- a/app/helpers/translatable_form_helper.rb +++ b/app/helpers/translatable_form_helper.rb @@ -18,7 +18,7 @@ module TranslatableFormHelper "highlight" if translations_interface_enabled? end - class TranslatableFormBuilder < FoundationRailsHelper::FormBuilder + class TranslatableFormBuilder < ConsulFormBuilder attr_accessor :translations def translatable_fields(&block) @@ -94,31 +94,9 @@ module TranslatableFormHelper end end - class TranslationsFieldsBuilder < FoundationRailsHelper::FormBuilder - %i[text_field text_area cktext_area].each do |field| - define_method field do |attribute, options = {}| - custom_label(attribute, options[:label], options[:label_options]) + - help_text(options[:hint]) + - super(attribute, options.merge(label: false, hint: false)) - end - end - + class TranslationsFieldsBuilder < ConsulFormBuilder def locale @object.locale end - - def label(attribute, text = nil, options = {}) - label_options = options.dup - hint = label_options.delete(:hint) - - super(attribute, text, label_options) + help_text(hint) - end - - private - def help_text(text) - if text - content_tag :span, text, class: "help-text" - end - end end end diff --git a/app/views/account/show.html.erb b/app/views/account/show.html.erb index b1fda5247..90ac292d5 100644 --- a/app/views/account/show.html.erb +++ b/app/views/account/show.html.erb @@ -32,82 +32,40 @@
- <%= t("admin.budget_headings.form.population_info") %> -
<%= f.text_field :population, - label: false, + label: t("admin.budget_headings.form.population"), maxlength: 8, placeholder: t("admin.budget_headings.form.population"), data: { toggle_focus: "population-info" }, - aria: { describedby: "budgets-population-help-text" } %> + hint: t("admin.budget_headings.form.population_info") %> <%= f.text_field :latitude, label: t("admin.budget_headings.form.latitude"), diff --git a/app/views/admin/budget_investments/_search_form.html.erb b/app/views/admin/budget_investments/_search_form.html.erb index 80b722bed..b6c24b1a1 100644 --- a/app/views/admin/budget_investments/_search_form.html.erb +++ b/app/views/admin/budget_investments/_search_form.html.erb @@ -35,33 +35,28 @@