From 241ee313f183cfe23f9f779aa9cebc5648a1bd82 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 29 Apr 2019 12:14:53 +0200 Subject: [PATCH] Use paths instead of URLs where possible It simplifies the code and solves any issue we might have configuring the host in the test environment. --- app/views/budgets/index.html.erb | 6 +++--- app/views/budgets/results/show.html.erb | 6 +++--- spec/features/budgets/budgets_spec.rb | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/views/budgets/index.html.erb b/app/views/budgets/index.html.erb index 6216eb2af..9e198156f 100644 --- a/app/views/budgets/index.html.erb +++ b/app/views/budgets/index.html.erb @@ -98,19 +98,19 @@ <% show_links = show_links_to_budget_investments(current_budget) %> <% if show_links %>
  • - <%= link_to budget_url(current_budget) do %> + <%= link_to budget_path(current_budget) do %> <%= t("budgets.index.investment_proyects") %> <% end %>
  • <% end %>
  • - <%= link_to budget_url(current_budget, filter: "unfeasible") do %> + <%= link_to budget_path(current_budget, filter: "unfeasible") do %> <%= t("budgets.index.unfeasible_investment_proyects") %> <% end %>
  • <% if show_links %>
  • - <%= link_to budget_url(current_budget, filter: "unselected") do %> + <%= link_to budget_path(current_budget, filter: "unselected") do %> <%= t("budgets.index.not_selected_investment_proyects") %> <% end %>
  • diff --git a/app/views/budgets/results/show.html.erb b/app/views/budgets/results/show.html.erb index 58916ae95..d77f50b77 100644 --- a/app/views/budgets/results/show.html.erb +++ b/app/views/budgets/results/show.html.erb @@ -76,13 +76,13 @@ <% end %>

    - <%= link_to budget_url(@budget) do %> + <%= link_to budget_path(@budget) do %> <%= t("budgets.results.investment_proyects") %> <% end %>
    - <%= link_to budget_url(@budget, filter: "unfeasible") do %> + <%= link_to budget_path(@budget, filter: "unfeasible") do %> <%= t("budgets.results.unfeasible_investment_proyects") %> <% end %>
    - <%= link_to budget_url(@budget, filter: "unselected") do %> + <%= link_to budget_path(@budget, filter: "unselected") do %> <%= t("budgets.results.not_selected_investment_proyects") %> <% end %>

    diff --git a/spec/features/budgets/budgets_spec.rb b/spec/features/budgets/budgets_spec.rb index 2d404fbd9..d6fdf13e0 100644 --- a/spec/features/budgets/budgets_spec.rb +++ b/spec/features/budgets/budgets_spec.rb @@ -120,13 +120,13 @@ describe "Budgets" do expect(page).to have_content "#{heading.name} €1,000,000" expect(page).to have_link "List of all investment projects", - href: budget_url(budget) + href: budget_path(budget) expect(page).to have_link "List of all unfeasible investment projects", - href: budget_url(budget, filter: "unfeasible") + href: budget_path(budget, filter: "unfeasible") expect(page).to have_link "List of all investment projects not selected for balloting", - href: budget_url(budget, filter: "unselected") + href: budget_path(budget, filter: "unselected") expect(page).to have_css("div.map") end