From 21021f5054da5d65cf845c7fe31c3aef38ddeba4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Tue, 19 Jan 2021 14:29:53 +0100
Subject: [PATCH] Remove instance variables in has_filters spec

This was a false positive in Rubocop, but we can avoid it by using the
attribute reader method we've just added.
---
 .rubocop.yml                                  | 1 -
 spec/controllers/concerns/has_filters_spec.rb | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index c3ebd2b40..ef3be1d85 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -360,7 +360,6 @@ RSpec/HookArgument:
 RSpec/InstanceVariable:
   Enabled: true
   Exclude:
-    - spec/controllers/concerns/has_filters_spec.rb
     - spec/controllers/concerns/has_orders_spec.rb
 
 RSpec/LetBeforeExamples:
diff --git a/spec/controllers/concerns/has_filters_spec.rb b/spec/controllers/concerns/has_filters_spec.rb
index c95531265..c921f6255 100644
--- a/spec/controllers/concerns/has_filters_spec.rb
+++ b/spec/controllers/concerns/has_filters_spec.rb
@@ -6,7 +6,7 @@ describe HasFilters do
     has_filters ["all", "pending", "reviewed"], only: :index
 
     def index
-      render plain: "#{@current_filter} (#{@valid_filters.join(" ")})"
+      render plain: "#{current_filter} (#{valid_filters.join(" ")})"
     end
   end