From 1f828bf4d486118d698efd420f99b78a3b888fbd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Fri, 28 Jun 2019 22:48:18 +0200
Subject: [PATCH] Simplify code to check form changes

---
 .../javascripts/watch_form_changes.js.coffee    | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/app/assets/javascripts/watch_form_changes.js.coffee b/app/assets/javascripts/watch_form_changes.js.coffee
index f2ee99569..5b56fb982 100644
--- a/app/assets/javascripts/watch_form_changes.js.coffee
+++ b/app/assets/javascripts/watch_form_changes.js.coffee
@@ -6,22 +6,21 @@ App.WatchFormChanges =
     if($("[data-watch-form-message]").length)
       return $("[data-watch-form-message]").data("watch-form-message")
 
+  hasChanged: ->
+    App.WatchFormChanges.forms().is ->
+      $(this).serialize() != $(this).data("watchChanges")
+
   checkChanges: ->
-    changes = false
-    App.WatchFormChanges.forms().each ->
-      form = $(this)
-      if form.serialize() != form.data("watchChanges")
-        changes = true
-    if changes
-      return confirm(App.WatchFormChanges.msg())
+    if App.WatchFormChanges.hasChanged()
+      confirm(App.WatchFormChanges.msg())
     else
-      return true
+      true
 
   initialize: ->
     if App.WatchFormChanges.forms().length == 0 || App.WatchFormChanges.msg() == undefined
       return
 
-    $(document).off("page:before-change").on("page:before-change", -> App.WatchFormChanges.checkChanges())
+    $(document).off("page:before-change").on("page:before-change", App.WatchFormChanges.checkChanges)
 
     App.WatchFormChanges.forms().each ->
       form = $(this)