Change header text in groups and headings section
The text "Groups and headings" might cause users to think both groups and headings have the same hierarchy, and wonder whether what they immediately see are groups or headings. Using "Heading groups" we make it clear that what comes immediately is a group, and then we see each group has headings.
This commit is contained in:
@@ -156,7 +156,7 @@ en:
|
|||||||
show:
|
show:
|
||||||
add_group: "Add group"
|
add_group: "Add group"
|
||||||
add_heading: "Add heading"
|
add_heading: "Add heading"
|
||||||
groups_and_headings: "Groups and headings"
|
groups_and_headings: "Heading groups"
|
||||||
headings_caption: "Headings in %{group}"
|
headings_caption: "Headings in %{group}"
|
||||||
winners:
|
winners:
|
||||||
calculate: Calculate Winner Investments
|
calculate: Calculate Winner Investments
|
||||||
|
|||||||
@@ -156,7 +156,7 @@ es:
|
|||||||
show:
|
show:
|
||||||
add_group: "Añadir grupo"
|
add_group: "Añadir grupo"
|
||||||
add_heading: "Añadir partida"
|
add_heading: "Añadir partida"
|
||||||
groups_and_headings: "Grupos y partidas"
|
groups_and_headings: "Grupos de partidas"
|
||||||
headings_caption: "Partidas del grupo %{group}"
|
headings_caption: "Partidas del grupo %{group}"
|
||||||
winners:
|
winners:
|
||||||
calculate: Calcular proyectos ganadores
|
calculate: Calcular proyectos ganadores
|
||||||
|
|||||||
@@ -18,8 +18,8 @@ describe "Admin budget groups", :admin do
|
|||||||
scenario "Displaying no groups for budget" do
|
scenario "Displaying no groups for budget" do
|
||||||
visit admin_budget_path(budget)
|
visit admin_budget_path(budget)
|
||||||
|
|
||||||
within "section", text: "Groups and headings" do
|
within "section", text: "Heading groups" do
|
||||||
expect(page.text).to eq "Groups and headings\nAdd group"
|
expect(page.text).to eq "Heading groups\nAdd group"
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
@@ -33,7 +33,7 @@ describe "Admin budget groups", :admin do
|
|||||||
|
|
||||||
visit admin_budget_path(budget)
|
visit admin_budget_path(budget)
|
||||||
|
|
||||||
within "section", text: "Groups and headings" do
|
within "section", text: "Heading groups" do
|
||||||
within "section", text: "Above ground" do
|
within "section", text: "Above ground" do
|
||||||
expect(page).to have_css "h4", exact_text: "Above ground"
|
expect(page).to have_css "h4", exact_text: "Above ground"
|
||||||
expect(page).not_to have_content "Maximum number of headings"
|
expect(page).not_to have_content "Maximum number of headings"
|
||||||
@@ -81,7 +81,7 @@ describe "Admin budget groups", :admin do
|
|||||||
|
|
||||||
expect(page).to have_content "Group created successfully!"
|
expect(page).to have_content "Group created successfully!"
|
||||||
|
|
||||||
within "section", text: "Groups and headings" do
|
within "section", text: "Heading groups" do
|
||||||
expect(page).to have_css "h4", exact_text: "All City"
|
expect(page).to have_css "h4", exact_text: "All City"
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -23,7 +23,7 @@ describe "Admin budget headings", :admin do
|
|||||||
|
|
||||||
visit admin_budget_path(budget)
|
visit admin_budget_path(budget)
|
||||||
|
|
||||||
within "section", text: "Groups and headings" do
|
within "section", text: "Heading groups" do
|
||||||
expect(page).to have_content "There are no headings in the Universities group."
|
expect(page).to have_content "There are no headings in the Universities group."
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
@@ -35,7 +35,7 @@ describe "Admin budget headings", :admin do
|
|||||||
|
|
||||||
visit admin_budget_path(budget)
|
visit admin_budget_path(budget)
|
||||||
|
|
||||||
within "section", text: "Groups and headings" do
|
within "section", text: "Heading groups" do
|
||||||
within "tbody" do
|
within "tbody" do
|
||||||
expect(page).to have_selector "tr", count: 3
|
expect(page).to have_selector "tr", count: 3
|
||||||
|
|
||||||
@@ -73,7 +73,7 @@ describe "Admin budget headings", :admin do
|
|||||||
scenario "Create heading" do
|
scenario "Create heading" do
|
||||||
visit admin_budget_path(budget)
|
visit admin_budget_path(budget)
|
||||||
|
|
||||||
within "section", text: "Groups and headings" do
|
within "section", text: "Heading groups" do
|
||||||
within("section", text: group.name) { click_link "Add heading" }
|
within("section", text: group.name) { click_link "Add heading" }
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
@@ -114,7 +114,7 @@ describe "Budgets wizard, groups step", :admin do
|
|||||||
|
|
||||||
visit admin_budget_path(budget)
|
visit admin_budget_path(budget)
|
||||||
|
|
||||||
within "section", text: "Groups and headings" do
|
within "section", text: "Heading groups" do
|
||||||
expect(page).to have_css "h4", exact_text: "Group without typos"
|
expect(page).to have_css "h4", exact_text: "Group without typos"
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -138,7 +138,7 @@ describe "Budgets wizard, headings step", :admin do
|
|||||||
|
|
||||||
visit admin_budget_path(budget)
|
visit admin_budget_path(budget)
|
||||||
|
|
||||||
within "section", text: "Groups and headings" do
|
within "section", text: "Heading groups" do
|
||||||
within("tbody tr") { expect(page).to have_content "Heading without typos" }
|
within("tbody tr") { expect(page).to have_content "Heading without typos" }
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -24,7 +24,7 @@ describe "Budgets creation wizard", :admin do
|
|||||||
|
|
||||||
click_link "Finish"
|
click_link "Finish"
|
||||||
|
|
||||||
within "section", text: "Groups and headings" do
|
within "section", text: "Heading groups" do
|
||||||
expect(page).to have_content "Single heading budget"
|
expect(page).to have_content "Single heading budget"
|
||||||
|
|
||||||
within "tbody" do
|
within "tbody" do
|
||||||
@@ -111,7 +111,7 @@ describe "Budgets creation wizard", :admin do
|
|||||||
|
|
||||||
click_link "Finish"
|
click_link "Finish"
|
||||||
|
|
||||||
within "section", text: "Groups and headings" do
|
within "section", text: "Heading groups" do
|
||||||
within "section", text: "All city" do
|
within "section", text: "All city" do
|
||||||
within_table "Headings in All city" do
|
within_table "Headings in All city" do
|
||||||
expect(page).to have_css "tbody tr", count: 1
|
expect(page).to have_css "tbody tr", count: 1
|
||||||
|
|||||||
Reference in New Issue
Block a user