From 1d6877b797d60fb0a95fb15a3eb8116b4b2fe215 Mon Sep 17 00:00:00 2001
From: decabeza <alberto@decabeza.es>
Date: Wed, 6 Dec 2017 20:59:34 +0100
Subject: [PATCH] adds setting allow_images to specs

---
 spec/features/budgets/investments_spec.rb | 10 +++++++++-
 spec/features/proposals_spec.rb           | 11 ++++++++++-
 spec/shared/features/nested_imageable.rb  |  7 +++++++
 3 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/spec/features/budgets/investments_spec.rb b/spec/features/budgets/investments_spec.rb
index fa7749a4b..ed11c5138 100644
--- a/spec/features/budgets/investments_spec.rb
+++ b/spec/features/budgets/investments_spec.rb
@@ -9,6 +9,14 @@ feature 'Budget Investments' do
   let(:group) { create(:budget_group, name: "Health", budget: budget) }
   let!(:heading) { create(:budget_heading, name: "More hospitals", group: group) }
 
+  before do
+    Setting['feature.allow_images'] = true
+  end
+
+  after do
+    Setting['feature.allow_images'] = nil
+  end
+
   scenario 'Index' do
     investments = [create(:budget_investment, heading: heading),
                    create(:budget_investment, heading: heading),
@@ -37,7 +45,7 @@ feature 'Budget Investments' do
     visit budget_investments_path(budget, heading_id: heading.id)
 
     within("#budget_investment_#{investment.id}") do
-      expect(page).to have_css("div.no-image")
+      expect(page).to_not have_css("div.with-image")
     end
     within("#budget_investment_#{investment_with_image.id}") do
       expect(page).to have_css("img[alt='#{investment_with_image.image.title}']")
diff --git a/spec/features/proposals_spec.rb b/spec/features/proposals_spec.rb
index 192e7949f..d5d3c84d0 100644
--- a/spec/features/proposals_spec.rb
+++ b/spec/features/proposals_spec.rb
@@ -4,6 +4,15 @@ require 'rails_helper'
 feature 'Proposals' do
 
   context 'Index' do
+
+    before do
+      Setting['feature.allow_images'] = true
+    end
+
+    after do
+      Setting['feature.allow_images'] = nil
+    end
+
     scenario 'Lists featured and regular proposals' do
       featured_proposals = create_featured_proposals
       proposals = [create(:proposal), create(:proposal), create(:proposal)]
@@ -55,7 +64,7 @@ feature 'Proposals' do
       visit proposals_path(proposal)
 
       within("#proposal_#{proposal.id}") do
-        expect(page).to have_css("div.no-image")
+        expect(page).to_not have_css("div.with-image")
       end
       within("#proposal_#{proposal_with_image.id}") do
         expect(page).to have_css("img[alt='#{proposal_with_image.image.title}']")
diff --git a/spec/shared/features/nested_imageable.rb b/spec/shared/features/nested_imageable.rb
index 947887afa..721c7e694 100644
--- a/spec/shared/features/nested_imageable.rb
+++ b/spec/shared/features/nested_imageable.rb
@@ -9,6 +9,9 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p
   let!(:imageable)           { create(imageable_factory_name) }
 
   before do
+
+    Setting['feature.allow_images'] = true
+
     imageable_path_arguments&.each do |argument_name, path_to_value|
         arguments.merge!("#{argument_name}": imageable.send(path_to_value))
     end
@@ -16,6 +19,10 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p
     imageable.update(author: user) if imageable.respond_to?(:author)
   end
 
+  after do
+    Setting['feature.allow_images'] = nil
+  end
+
   describe "at #{path}" do
 
     scenario "Should show new image link when imageable has not an associated image defined" do