From 18813c8f2a3bde54fc332a6f7dc18325e654937c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sun, 8 Nov 2020 15:12:43 +0100 Subject: [PATCH] Specify styles are meant for the main header The
tag is a standard HTML tag which can be used in any section of the page. We were adding the main header styles to all
tags because in the past it was in only
tag we used. That's not the case anymore, so instead of overwriting these styles on every other
tag, modifying the rule so it only selects the main header makes the code easier to maintain. --- app/assets/stylesheets/layout.scss | 3 ++- app/assets/stylesheets/legislation_process.scss | 6 ------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss index 61c438ef1..fae431c76 100644 --- a/app/assets/stylesheets/layout.scss +++ b/app/assets/stylesheets/layout.scss @@ -501,7 +501,8 @@ a { // 02. Header // ---------- -header { +body > header, +.wrapper > header { background: $brand; border-bottom: 1px solid $border; margin-bottom: $line-height; diff --git a/app/assets/stylesheets/legislation_process.scss b/app/assets/stylesheets/legislation_process.scss index 0b557a869..792c19c1c 100644 --- a/app/assets/stylesheets/legislation_process.scss +++ b/app/assets/stylesheets/legislation_process.scss @@ -996,12 +996,6 @@ @include grid-row; margin-top: $line-height * 1.5; padding: 0 rem-calc(16); - - > header { - background: none; - border: 0; - margin: 0; - } } h4,