Hides sidebar menus if officer has no shifts assigned

app/helpers/officers_helper.rb

@@ -4,4 +4,12 @@ module OfficersHelper
     truncate([officer.name, officer.email].compact.join(' - '), length: 100)
   end
 
+  def vote_collection_shift?
+    current_user.poll_officer.officer_assignments.where(date: Time.current.to_date).any?
+  end
+
+  def final_recount_shift?
+    current_user.poll_officer.officer_assignments.final.where(date: Time.current.to_date).any?
+  end
+
 end

app/views/officing/_menu.html.erb

@@ -1,18 +1,21 @@
 <div class="admin-sidebar" data-equalizer-watch>
   <ul id="officing_menu">
+    <% if vote_collection_shift? %>
+      <li <%= "class=is-active" if controller_name == "voters" %>>
+        <%= link_to new_officing_residence_path do %>
+          <span class="icon-user"></span>
+          <%= t("officing.menu.voters") %>
+        <% end %>
+      </li>
+    <% end %>
 
-    <li <%= "class=is-active" if controller_name == "voters" %>>
+    <% if final_recount_shift? %>
-      <%= link_to new_officing_residence_path do %>
+      <li <%= "class=is-active" if ["results"].include?(controller_name) || (controller_name == "polls" && action_name == "final") %>>
-        <span class="icon-user"></span>
+        <%= link_to final_officing_polls_path do %>
-        <%= t("officing.menu.voters") %>
+          <span class="icon-user"></span>
-      <% end %>
+          <%= t("officing.menu.total_recounts") %>
-    </li>
+        <% end %>
-
+      </li>
-    <li <%= "class=is-active" if ["results"].include?(controller_name) || (controller_name == "polls" && action_name == "final") %>>
+    <% end%>
-      <%= link_to final_officing_polls_path do %>
-        <span class="icon-user"></span>
-        <%= t("officing.menu.total_recounts") %>
-      <% end %>
-    </li>
   </ul>
 </div>

app/views/officing/dashboard/index.html.erb

@@ -2,4 +2,10 @@
   <h2><%= t("officing.dashboard.index.title") %></h2>
 
   <p><%= t("officing.dashboard.index.info") %></p>
+
+  <% unless final_recount_shift? && vote_collection_shift? %>
+    <div class="callout warning">
+      <%= t("officing.dashboard.index.no_shifts") %>
+    </div>
+  <% end %>
 </div>

config/locales/en/officing.yml

@@ -6,6 +6,7 @@ en:
       index:
         title: Poll officing
         info: Here you can validate user documents and store voting results
+        no_shifts: You don't have officing shifts today.
     menu:
       voters: Validate document
       total_recounts: Total recounts and results

config/locales/es/officing.yml

@@ -6,6 +6,7 @@ es:
       index:
         title: Presidir mesa de votaciones
         info: Aquí puedes validar documentos de ciudadanos y guardar los resultados de las urnas
+        no_shifts: No tienes turnos de presidente de mesa asignados hoy.
     menu:
       voters: Validar documento y votar
       total_recounts: Recuento total y escrutinio

spec/features/budget_polls/officing_spec.rb

@@ -0,0 +1,40 @@
+require 'rails_helper'
+
+feature 'Budget Poll Officing' do
+
+  scenario 'Show sidebar menu if officer has shifts assigned' do
+    budget = create(:budget)
+    poll = create(:poll, budget: budget)
+    booth = create(:poll_booth)
+    booth_assignment = create(:poll_booth_assignment, poll: poll, booth: booth)
+
+    user = create(:user)
+    officer = create(:poll_officer, user: user)
+
+    create(:poll_shift, officer: officer, booth: booth, date: Date.current, task: :recount_scrutiny)
+
+    officer_assignment = create(:poll_officer_assignment,
+                                 booth_assignment: booth_assignment,
+                                 officer: officer)
+
+    login_as user
+    visit officing_root_path
+
+    expect(page).not_to have_content("You don't have officing shifts today")
+    expect(page).to have_content("Validate document")
+    expect(page).to have_content("Total recounts and results")
+  end
+
+  scenario 'Do not show sidebar menu if officer has no shifts assigned' do
+    user = create(:user)
+    officer = create(:poll_officer, user: user)
+
+    login_as user
+    visit officing_root_path
+
+    expect(page).to have_content("You don't have officing shifts today")
+    expect(page).not_to have_content("Validate document")
+    expect(page).not_to have_content("Total recounts and results")
+  end
+
+end

spec/features/officing/residence_spec.rb

@@ -9,10 +9,7 @@ feature 'Residence' do
       login_as(officer.user)
       visit officing_root_path
 
-      within("#side_menu") do
+      expect(page).not_to have_link("Validate document")
-        click_link "Validate document"
-      end
-
       expect(page).to have_content("You don't have officing shifts today")
 
       create(:poll_officer_assignment, officer: officer, date: 1.day.from_now)