Enable RSpec/RepeatedExample cop & fix all issues

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedExample
This commit is contained in:
Bertocq
2018-01-07 17:49:18 +01:00
parent 4f6597b200
commit 16eae689f9
5 changed files with 5 additions and 34 deletions

View File

@@ -158,4 +158,7 @@ RSpec/PredicateMatcher:
Enabled: true Enabled: true
RSpec/RepeatedDescription: RSpec/RepeatedDescription:
Enabled: true
RSpec/RepeatedExample:
Enabled: true Enabled: true

View File

@@ -210,15 +210,6 @@ feature 'Emails' do
end end
end end
scenario "Email depending on user's locale" do
sign_up
email = open_last_email
expect(email).to have_subject('Confirmation instructions')
expect(email).to deliver_to('manuela@consul.dev')
expect(email).to have_body_text(user_confirmation_path)
end
scenario "Email on unfeasible spending proposal" do scenario "Email on unfeasible spending proposal" do
Setting["feature.spending_proposals"] = true Setting["feature.spending_proposals"] = true

View File

@@ -36,12 +36,6 @@ feature "Home" do
Setting['feature.user.recommendations'] = nil Setting['feature.user.recommendations'] = nil
end end
scenario 'Display recommended section' do
debate = create(:debate, tag_list: "Sport")
visit root_path
expect(page).to have_content "Recommendations that may interest you"
end
scenario 'Display recommended section when feature flag recommended is active' do scenario 'Display recommended section when feature flag recommended is active' do
debate = create(:debate, tag_list: "Sport") debate = create(:debate, tag_list: "Sport")
visit root_path visit root_path

View File

@@ -53,24 +53,7 @@ feature 'Tracking' do
expect(page.html).to include "data-track-event-action=start_census" expect(page.html).to include "data-track-event-action=start_census"
end end
scenario 'Verification: success census' do scenario 'Verification: success census & start sms' do
create(:geozone)
user = create(:user)
login_as(user)
visit account_path
click_link 'Verify my account'
verify_residence
fill_in 'sms_phone', with: "611111111"
click_button 'Send'
expect(page.html).to include "data-track-event-category=verification"
expect(page.html).to include "data-track-event-action=start_sms"
end
scenario 'Verification: start sms' do
create(:geozone) create(:geozone)
user = create(:user) user = create(:user)
login_as(user) login_as(user)

View File

@@ -230,7 +230,7 @@ describe Abilities::Common do
it { should be_able_to(:destroy, own_investment_in_accepting_budget) } it { should be_able_to(:destroy, own_investment_in_accepting_budget) }
it { should be_able_to(:destroy, own_investment_in_reviewing_budget) } it { should be_able_to(:destroy, own_investment_in_reviewing_budget) }
it { should_not be_able_to(:destroy, own_investment_in_selecting_budget) } it { should_not be_able_to(:destroy, own_investment_in_selecting_budget) }
it { should_not be_able_to(:destroy, investment_in_balloting_budget) } it { should_not be_able_to(:destroy, own_investment_in_balloting_budget) }
it { should_not be_able_to(:create, ballot_in_accepting_budget) } it { should_not be_able_to(:create, ballot_in_accepting_budget) }
it { should_not be_able_to(:create, ballot_in_selecting_budget) } it { should_not be_able_to(:create, ballot_in_selecting_budget) }