From 16dc5821d1a063d05a0db62b291e8ef99ce9938f Mon Sep 17 00:00:00 2001
From: decabeza <alberto@decabeza.es>
Date: Mon, 16 Mar 2020 12:54:00 +0100
Subject: [PATCH] Add margin to all h3 admin headers

---
 app/assets/stylesheets/admin.scss                             | 4 ++++
 app/views/admin/activity/show.html.erb                        | 2 +-
 app/views/admin/administrators/index.html.erb                 | 2 +-
 app/views/admin/administrators/search.html.erb                | 2 +-
 app/views/admin/hidden_budget_investments/index.html.erb      | 2 +-
 app/views/admin/hidden_comments/index.html.erb                | 2 +-
 app/views/admin/hidden_debates/index.html.erb                 | 2 +-
 app/views/admin/hidden_proposal_notifications/index.html.erb  | 2 +-
 app/views/admin/hidden_proposals/index.html.erb               | 2 +-
 app/views/admin/hidden_users/index.html.erb                   | 2 +-
 .../admin/local_census_records/_local_census_records.html.erb | 2 +-
 app/views/admin/managers/index.html.erb                       | 2 +-
 app/views/admin/moderators/index.html.erb                     | 2 +-
 app/views/admin/moderators/search.html.erb                    | 2 +-
 app/views/admin/officials/index.html.erb                      | 2 +-
 app/views/admin/organizations/index.html.erb                  | 2 +-
 app/views/admin/organizations/search.html.erb                 | 2 +-
 app/views/admin/tags/index.html.erb                           | 2 +-
 app/views/admin/users/_users.html.erb                         | 2 +-
 app/views/admin/valuator_groups/index.html.erb                | 2 +-
 app/views/admin/valuators/index.html.erb                      | 2 +-
 app/views/admin/valuators/search.html.erb                     | 2 +-
 22 files changed, 25 insertions(+), 21 deletions(-)

diff --git a/app/assets/stylesheets/admin.scss b/app/assets/stylesheets/admin.scss
index 597870045..04cfd0161 100644
--- a/app/assets/stylesheets/admin.scss
+++ b/app/assets/stylesheets/admin.scss
@@ -42,6 +42,10 @@ $table-header:   #ecf1f6;
     }
   }
 
+  h3 {
+    margin: $line-height 0;
+  }
+
   .back {
     float: none;
   }
diff --git a/app/views/admin/activity/show.html.erb b/app/views/admin/activity/show.html.erb
index 325e70857..01d2623e7 100644
--- a/app/views/admin/activity/show.html.erb
+++ b/app/views/admin/activity/show.html.erb
@@ -5,7 +5,7 @@
 <%= render "shared/filter_subnav", i18n_namespace: "admin.activity.show" %>
 
 <% if @activity.any? %>
-  <h3 class="margin"><%= page_entries_info @activity %></h3>
+  <h3><%= page_entries_info @activity %></h3>
 
   <table>
     <thead>
diff --git a/app/views/admin/administrators/index.html.erb b/app/views/admin/administrators/index.html.erb
index 8d58e38bc..e2a44bc50 100644
--- a/app/views/admin/administrators/index.html.erb
+++ b/app/views/admin/administrators/index.html.erb
@@ -4,7 +4,7 @@
 
 <div id="administrators">
   <% if @administrators.any? %>
-    <h3 class="margin"><%= page_entries_info @administrators %></h3>
+    <h3><%= page_entries_info @administrators %></h3>
 
     <table>
       <thead>
diff --git a/app/views/admin/administrators/search.html.erb b/app/views/admin/administrators/search.html.erb
index 4d971ba53..112f9ec8f 100644
--- a/app/views/admin/administrators/search.html.erb
+++ b/app/views/admin/administrators/search.html.erb
@@ -4,7 +4,7 @@
 
 <div id="administrators">
   <% if @users.any? %>
-    <h3 class="margin"><%= page_entries_info @users %></h3>
+    <h3><%= page_entries_info @users %></h3>
 
     <table>
       <thead>
diff --git a/app/views/admin/hidden_budget_investments/index.html.erb b/app/views/admin/hidden_budget_investments/index.html.erb
index 90213a5ed..0fa2879ac 100644
--- a/app/views/admin/hidden_budget_investments/index.html.erb
+++ b/app/views/admin/hidden_budget_investments/index.html.erb
@@ -4,7 +4,7 @@
 <%= render "shared/filter_subnav", i18n_namespace: "admin.hidden_budget_investments.index" %>
 
 <% if @investments.any? %>
-  <h3 class="margin"><%= page_entries_info @investments %></h3>
+  <h3><%= page_entries_info @investments %></h3>
 
   <table>
     <thead>
diff --git a/app/views/admin/hidden_comments/index.html.erb b/app/views/admin/hidden_comments/index.html.erb
index d52f4f68a..dbf9c84a1 100644
--- a/app/views/admin/hidden_comments/index.html.erb
+++ b/app/views/admin/hidden_comments/index.html.erb
@@ -4,7 +4,7 @@
 <%= render "shared/filter_subnav", i18n_namespace: "admin.hidden_comments.index" %>
 
 <% if @comments.any? %>
-  <h3 class="margin"><%= page_entries_info @comments %></h3>
+  <h3><%= page_entries_info @comments %></h3>
 
   <table>
     <thead>
diff --git a/app/views/admin/hidden_debates/index.html.erb b/app/views/admin/hidden_debates/index.html.erb
index 954ecf854..3074ab646 100644
--- a/app/views/admin/hidden_debates/index.html.erb
+++ b/app/views/admin/hidden_debates/index.html.erb
@@ -4,7 +4,7 @@
 <%= render "shared/filter_subnav", i18n_namespace: "admin.hidden_debates.index" %>
 
 <% if @debates.any? %>
-  <h3 class="margin"><%= page_entries_info @debates %></h3>
+  <h3><%= page_entries_info @debates %></h3>
 
   <table>
     <thead>
diff --git a/app/views/admin/hidden_proposal_notifications/index.html.erb b/app/views/admin/hidden_proposal_notifications/index.html.erb
index 5b17b7dce..31aafc141 100644
--- a/app/views/admin/hidden_proposal_notifications/index.html.erb
+++ b/app/views/admin/hidden_proposal_notifications/index.html.erb
@@ -4,7 +4,7 @@
 <%= render "shared/filter_subnav", i18n_namespace: "admin.hidden_proposal_notifications.index" %>
 
 <% if @proposal_notifications.any? %>
-  <h3 class="margin"><%= page_entries_info @proposal_notifications %></h3>
+  <h3><%= page_entries_info @proposal_notifications %></h3>
 
   <table>
     <thead>
diff --git a/app/views/admin/hidden_proposals/index.html.erb b/app/views/admin/hidden_proposals/index.html.erb
index b9502d7bc..c28f0f5d4 100644
--- a/app/views/admin/hidden_proposals/index.html.erb
+++ b/app/views/admin/hidden_proposals/index.html.erb
@@ -4,7 +4,7 @@
 <%= render "shared/filter_subnav", i18n_namespace: "admin.hidden_proposals.index" %>
 
 <% if @proposals.any? %>
-  <h3 class="margin"><%= page_entries_info @proposals %></h3>
+  <h3><%= page_entries_info @proposals %></h3>
 
   <table>
     <thead>
diff --git a/app/views/admin/hidden_users/index.html.erb b/app/views/admin/hidden_users/index.html.erb
index bb2387e9f..c4addaeda 100644
--- a/app/views/admin/hidden_users/index.html.erb
+++ b/app/views/admin/hidden_users/index.html.erb
@@ -4,7 +4,7 @@
 <%= render "shared/filter_subnav", i18n_namespace: "admin.hidden_users.index" %>
 
 <% if @users.any? %>
-  <h3 class="margin"><%= page_entries_info @users %></h3>
+  <h3><%= page_entries_info @users %></h3>
 
   <table>
     <thead>
diff --git a/app/views/admin/local_census_records/_local_census_records.html.erb b/app/views/admin/local_census_records/_local_census_records.html.erb
index d8549ab30..a712ceded 100644
--- a/app/views/admin/local_census_records/_local_census_records.html.erb
+++ b/app/views/admin/local_census_records/_local_census_records.html.erb
@@ -1,5 +1,5 @@
 <% if @local_census_records.any? %>
-  <h3 class="margin"><%= page_entries_info @local_census_records %></h3>
+  <h3><%= page_entries_info @local_census_records %></h3>
   <table>
     <thead>
       <tr>
diff --git a/app/views/admin/managers/index.html.erb b/app/views/admin/managers/index.html.erb
index 90fc86772..acd8b4978 100644
--- a/app/views/admin/managers/index.html.erb
+++ b/app/views/admin/managers/index.html.erb
@@ -4,7 +4,7 @@
 
 <div id="managers">
   <% if @managers.any? %>
-    <h3 class="margin"><%= page_entries_info @managers %></h3>
+    <h3><%= page_entries_info @managers %></h3>
 
     <table>
       <thead>
diff --git a/app/views/admin/moderators/index.html.erb b/app/views/admin/moderators/index.html.erb
index 2ded206e5..8a0bd5dee 100644
--- a/app/views/admin/moderators/index.html.erb
+++ b/app/views/admin/moderators/index.html.erb
@@ -6,7 +6,7 @@
 
 <div id="moderators">
   <% if @moderators.any? %>
-    <h3 class="margin"><%= page_entries_info @moderators %></h3>
+    <h3><%= page_entries_info @moderators %></h3>
 
     <table>
       <thead>
diff --git a/app/views/admin/moderators/search.html.erb b/app/views/admin/moderators/search.html.erb
index bf2ed25f4..fee2c76a7 100644
--- a/app/views/admin/moderators/search.html.erb
+++ b/app/views/admin/moderators/search.html.erb
@@ -4,7 +4,7 @@
 
 <div id="moderators">
   <% if @users.any? %>
-    <h3 class="margin"><%= page_entries_info @users %></h3>
+    <h3><%= page_entries_info @users %></h3>
 
     <table id="moderators">
       <thead>
diff --git a/app/views/admin/officials/index.html.erb b/app/views/admin/officials/index.html.erb
index b62a450b6..f3c930434 100644
--- a/app/views/admin/officials/index.html.erb
+++ b/app/views/admin/officials/index.html.erb
@@ -4,7 +4,7 @@
 <%= render "admin/shared/user_search", url: search_admin_officials_path %>
 
 <% if @officials.any? %>
-  <h3 class="margin"><%= page_entries_info @officials %></h3>
+  <h3><%= page_entries_info @officials %></h3>
 
   <table>
     <thead>
diff --git a/app/views/admin/organizations/index.html.erb b/app/views/admin/organizations/index.html.erb
index c320087e8..7632445be 100644
--- a/app/views/admin/organizations/index.html.erb
+++ b/app/views/admin/organizations/index.html.erb
@@ -8,7 +8,7 @@
 <%= render "shared/filter_subnav", i18n_namespace: "admin.organizations.index" %>
 
 <% if @organizations.any? %>
-  <h3 class="margin"><%= page_entries_info @organizations %></h3>
+  <h3><%= page_entries_info @organizations %></h3>
 
   <table>
     <% hidden = 0 %>
diff --git a/app/views/admin/organizations/search.html.erb b/app/views/admin/organizations/search.html.erb
index 7da60dc2c..f19ee42c6 100644
--- a/app/views/admin/organizations/search.html.erb
+++ b/app/views/admin/organizations/search.html.erb
@@ -4,7 +4,7 @@
 
 <div id="search-results">
   <% if @organizations.any? %>
-    <h3 class="margin"><%= page_entries_info @organizations %></h3>
+    <h3><%= page_entries_info @organizations %></h3>
 
     <table>
       <thead>
diff --git a/app/views/admin/tags/index.html.erb b/app/views/admin/tags/index.html.erb
index d50d4283b..e2bfaeac3 100644
--- a/app/views/admin/tags/index.html.erb
+++ b/app/views/admin/tags/index.html.erb
@@ -10,7 +10,7 @@
 <% end %>
 
 <hr>
-<h3 class="margin"><%= t("admin.tags.index.title") %>: <%= page_entries_info @tags %></h3>
+<h3><%= t("admin.tags.index.title") %>: <%= page_entries_info @tags %></h3>
 
 <table>
   <thead>
diff --git a/app/views/admin/users/_users.html.erb b/app/views/admin/users/_users.html.erb
index 5334d1c11..c03f17fe9 100644
--- a/app/views/admin/users/_users.html.erb
+++ b/app/views/admin/users/_users.html.erb
@@ -1,7 +1,7 @@
 <%= render "shared/filter_subnav", i18n_namespace: "admin.users.index" %>
 
 <% if @users.any? %>
-  <h3 class="margin"><%= page_entries_info @users %></h3>
+  <h3><%= page_entries_info @users %></h3>
 
   <table>
     <thead>
diff --git a/app/views/admin/valuator_groups/index.html.erb b/app/views/admin/valuator_groups/index.html.erb
index 15a1ab2dd..53024f428 100644
--- a/app/views/admin/valuator_groups/index.html.erb
+++ b/app/views/admin/valuator_groups/index.html.erb
@@ -3,7 +3,7 @@
 <%= link_to t("admin.valuator_groups.index.new"), new_admin_valuator_group_path, class: "button float-right" %>
 
 <% if @groups.any? %>
-  <h3 class="margin"><%= page_entries_info @groups %></h3>
+  <h3><%= page_entries_info @groups %></h3>
 
   <table>
     <thead>
diff --git a/app/views/admin/valuators/index.html.erb b/app/views/admin/valuators/index.html.erb
index 7f9489722..fa8a0879d 100644
--- a/app/views/admin/valuators/index.html.erb
+++ b/app/views/admin/valuators/index.html.erb
@@ -6,7 +6,7 @@
 
 <div id="valuators">
   <% if @valuators.any? %>
-    <h3 class="margin"><%= page_entries_info @valuators %></h3>
+    <h3><%= page_entries_info @valuators %></h3>
 
     <%= render "valuators", valuators: @valuators %>
 
diff --git a/app/views/admin/valuators/search.html.erb b/app/views/admin/valuators/search.html.erb
index faa999c31..058949a4d 100644
--- a/app/views/admin/valuators/search.html.erb
+++ b/app/views/admin/valuators/search.html.erb
@@ -4,7 +4,7 @@
 
 <div id="valuators">
   <% if @users.any? %>
-    <h3 class="margin"><%= page_entries_info @users %></h3>
+    <h3><%= page_entries_info @users %></h3>
     <%= render "valuators", valuators: @users %>
   <% else %>
     <div class="callout alert margin">