Add and apply Style/SuperArguments rubocop rule
This rule was added in rubocop 1.64.0. For clarity, in order to make it obvious that we're modifying the object we received, we're excluding the Ahoy initializer, whose code was copied from the Ahoy documentation. We're also changing the `Types::BaseObject` class so we don't use a variable with the same name as the parameter and we don't get a false positive for this rule.
This commit is contained in:
@@ -796,6 +796,11 @@ Style/StringLiterals:
|
||||
Style/StringLiteralsInInterpolation:
|
||||
EnforcedStyle: double_quotes
|
||||
|
||||
Style/SuperArguments:
|
||||
Enabled: true
|
||||
Exclude:
|
||||
- "config/initializers/ahoy.rb"
|
||||
|
||||
Style/SymbolProc:
|
||||
Enabled: true
|
||||
AllowedMethods:
|
||||
|
||||
@@ -19,7 +19,7 @@ class Users::OmniauthCallbacksController < Devise::OmniauthCallbacksController
|
||||
if resource.registering_with_oauth
|
||||
finish_signup_path
|
||||
else
|
||||
super(resource)
|
||||
super
|
||||
end
|
||||
end
|
||||
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
module Types
|
||||
class BaseObject < GraphQL::Schema::Object
|
||||
def self.field(*args, **kwargs, &)
|
||||
super(*args, **kwargs, &)
|
||||
super
|
||||
|
||||
# The old api contained non-camelized fields
|
||||
# We want to support these for now, but throw a deprecation warning
|
||||
@@ -13,8 +13,7 @@ module Types
|
||||
|
||||
if field_name.to_s.include?("_")
|
||||
reason = "Snake case fields are deprecated. Please use #{field_name.to_s.camelize(:lower)}."
|
||||
kwargs = kwargs.merge({ camelize: false, deprecation_reason: reason })
|
||||
super(*args, **kwargs, &)
|
||||
super(*args, **kwargs.merge({ camelize: false, deprecation_reason: reason }), &)
|
||||
end
|
||||
|
||||
# Make sure associations only return public records
|
||||
|
||||
@@ -27,7 +27,7 @@ module ActsAsParanoidAliases
|
||||
def restore(opts = {})
|
||||
return false unless hidden?
|
||||
|
||||
super(opts)
|
||||
super
|
||||
update_attribute(:confirmed_hide_at, nil) if self.class.column_names.include? "confirmed_hide_at"
|
||||
after_restore
|
||||
end
|
||||
|
||||
@@ -5,8 +5,6 @@ class DeviseMailer < Devise::Mailer
|
||||
protected
|
||||
|
||||
def devise_mail(record, action, opts = {})
|
||||
I18n.with_locale record.locale do
|
||||
super(record, action, opts)
|
||||
end
|
||||
I18n.with_locale(record.locale) { super }
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user