diff --git a/.erb-lint.yml b/.erb-lint.yml index 895a9d799..71b368cee 100644 --- a/.erb-lint.yml +++ b/.erb-lint.yml @@ -2,10 +2,12 @@ linters: FinalNewline: enabled: true - SpaceAroundErbTag: - enabled: true SelfClosingTag: enabled: false + SpaceAroundErbTag: + enabled: true + SpaceInHtmlTag: + enabled: true Rubocop: enabled: true only: diff --git a/app/controllers/concerns/commentable_actions.rb b/app/controllers/concerns/commentable_actions.rb index 2c6d1da81..bb610d4a6 100644 --- a/app/controllers/concerns/commentable_actions.rb +++ b/app/controllers/concerns/commentable_actions.rb @@ -16,7 +16,7 @@ module CommentableActions @resources = @resources.page(params[:page]).send("sort_by_#{@current_order}") - index_customization if index_customization.present? + index_customization @tag_cloud = tag_cloud @banners = Banner.in_section(section(resource_model.name)).with_active diff --git a/app/helpers/settings.rb b/app/helpers/settings.rb deleted file mode 100644 index 209237f99..000000000 --- a/app/helpers/settings.rb +++ /dev/null @@ -1,7 +0,0 @@ -module SettingsHelper - - def setting_for_widget(widget) - Setting.where(key: "feature.user.recommendations").first - end - -end diff --git a/app/models/geozone.rb b/app/models/geozone.rb index 345e040d1..667ec98f7 100644 --- a/app/models/geozone.rb +++ b/app/models/geozone.rb @@ -13,10 +13,6 @@ class Geozone < ApplicationRecord Geozone.pluck(:name) end - def self.city - where(name: "city").first - end - def safe_to_destroy? Geozone.reflect_on_all_associations(:has_many).all? do |association| association.klass.where(geozone: self).empty? diff --git a/app/views/admin/settings/_configuration_settings_tab.html.erb b/app/views/admin/settings/_configuration_settings_tab.html.erb index 84f21559b..b33fa9371 100644 --- a/app/views/admin/settings/_configuration_settings_tab.html.erb +++ b/app/views/admin/settings/_configuration_settings_tab.html.erb @@ -1,3 +1,3 @@ -

<%= t("admin.settings.index.title") %>

+

<%= t("admin.settings.index.general") %>

<%= render "settings_table", settings: @configuration_settings, setting_name: "setting", tab: "#tab-configuration" %> diff --git a/app/views/admin/settings/_filter_subnav.html.erb b/app/views/admin/settings/_filter_subnav.html.erb index 09d2d240b..cdd095d0d 100644 --- a/app/views/admin/settings/_filter_subnav.html.erb +++ b/app/views/admin/settings/_filter_subnav.html.erb @@ -7,7 +7,7 @@ data-tabs>
  • <%= link_to "#tab-configuration" do %> - <%= t("admin.settings.index.title") %> + <%= t("admin.settings.index.general") %> <% end %>
  • diff --git a/app/views/admin/settings/index.html.erb b/app/views/admin/settings/index.html.erb index 56d727887..9e417dc0e 100644 --- a/app/views/admin/settings/index.html.erb +++ b/app/views/admin/settings/index.html.erb @@ -1,4 +1,4 @@ -

    Settings

    +

    <%= t("admin.settings.index.title") %>

    <%= render "filter_subnav" %> diff --git a/app/views/admin/shared/_columns_selector.html.erb b/app/views/admin/shared/_columns_selector.html.erb index a48a17f3f..dfae1d808 100644 --- a/app/views/admin/shared/_columns_selector.html.erb +++ b/app/views/admin/shared/_columns_selector.html.erb @@ -1,11 +1,11 @@ "> - Columns + <%= t("admin.budget_investments.index.columns") %> diff --git a/app/views/admin/trackers/_form.html.erb b/app/views/admin/trackers/_form.html.erb deleted file mode 100644 index f9385c65a..000000000 --- a/app/views/admin/trackers/_form.html.erb +++ /dev/null @@ -1,32 +0,0 @@ -<%= form_for(tracker) do |f| %> - <% if tracker.errors.any? %> -
    -

    <%= pluralize(tracker.errors.count, "error") %> prohibited this tracker from being saved:

    - - -
    - <% end %> - -
    - <%= f.label :user_id %> - <%= f.text_field :user_id %> -
    - -
    - <%= f.label :description %> - <%= f.text_field :description %> -
    - -
    - <%= f.label :budget_investment_count %> - <%= f.number_field :budget_investment_count %> -
    - -
    - <%= f.submit %> -
    -<% end %> diff --git a/app/views/layouts/mailer.html.erb b/app/views/layouts/mailer.html.erb index 9431845dd..b11d38a3a 100644 --- a/app/views/layouts/mailer.html.erb +++ b/app/views/layouts/mailer.html.erb @@ -1,7 +1,7 @@ - Gobierno abierto + <%= t("mailers.title") %> diff --git a/app/views/management/user_invites/new.html.erb b/app/views/management/user_invites/new.html.erb index b8687e82d..f8d0aae26 100644 --- a/app/views/management/user_invites/new.html.erb +++ b/app/views/management/user_invites/new.html.erb @@ -7,6 +7,6 @@ placeholder: t("management.user_invites.new.info"), aria: {describedby: "emails-help-text"} %>
    - ", class="button expanded"> + " class="button expanded">
    <% end %> diff --git a/app/views/polls/questions/_new_answer.html.erb b/app/views/polls/questions/_new_answer.html.erb index 2f056bafa..9df88a7e7 100644 --- a/app/views/polls/questions/_new_answer.html.erb +++ b/app/views/polls/questions/_new_answer.html.erb @@ -1,5 +1,6 @@ <%= form_tag(create_answer_question_path(question, token: token), method: :post, remote: true) do %> - - - "> + <% id = "your_answer_#{SecureRandom.hex}" %> + <%= label_tag :answer, t("poll_questions.show.your_answer"), for: id %> + <%= text_field_tag :answer, nil, class: "medium-10", id: id %> + <%= submit_tag t("poll_questions.show.add_answer"), class: "button success" %> <% end %> diff --git a/app/views/shared/_advanced_search.html.erb b/app/views/shared/_advanced_search.html.erb index dc82c0714..5399da18d 100644 --- a/app/views/shared/_advanced_search.html.erb +++ b/app/views/shared/_advanced_search.html.erb @@ -4,7 +4,7 @@
    <%= form_tag search_path, id: "advanced_search_form", method: :get do %> -