consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enable RSpec/HookArgument cop and fix issues

Browse Source 
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
This commit is contained in:
Bertocq
2018-01-07 02:07:19 +01:00
parent 39b01b6342
commit 1441de5107
25 changed files with 46 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/models/user_spec.rb
View File

@@ -176,7 +176,7 @@ describe User do
end
describe 'when it is an organization' do
before(:each) { create(:organization, user: subject) }
before { create(:organization, user: subject) }
it "is true when the user is an organization" do
expect(subject.organization?).to be true
@@ -194,7 +194,7 @@ describe User do
end
describe 'when it is an organization' do
before(:each) { create(:organization, user: subject) }
before { create(:organization, user: subject) }
it "is false when the user is not a verified organization" do
expect(subject).to_not be_verified_organization
@@ -208,7 +208,7 @@ describe User do
end
describe "organization_attributes" do
before(:each) { subject.organization_attributes = {name: 'org', responsible_name: 'julia'} }
before { subject.organization_attributes = {name: 'org', responsible_name: 'julia'} }
it "triggers the creation of an associated organization" do
expect(subject.organization).to be