diff --git a/app/controllers/admin/valuators_controller.rb b/app/controllers/admin/valuators_controller.rb index 5b881c96a..cb1960529 100644 --- a/app/controllers/admin/valuators_controller.rb +++ b/app/controllers/admin/valuators_controller.rb @@ -31,7 +31,7 @@ class Admin::ValuatorsController < Admin::BaseController def update @valuator = Valuator.find(params[:id]) if @valuator.update(valuator_params) - notice = "Valuator updated successfully" + notice = t("admin.valuators.form.updated") redirect_to [:admin, @valuator], notice: notice else render :edit diff --git a/app/views/admin/budget_investments/edit.html.erb b/app/views/admin/budget_investments/edit.html.erb index 533053530..fc56f88df 100644 --- a/app/views/admin/budget_investments/edit.html.erb +++ b/app/views/admin/budget_investments/edit.html.erb @@ -9,7 +9,7 @@ <%= hidden_field_tag filter_name, filter_value %> <% end %> -
+
<%= f.text_field :title, maxlength: Budget::Investment.title_max_length %>
@@ -26,22 +26,26 @@
- <%= f.text_field :external_url %> -
+
+ <%= f.text_field :external_url %> +
-
- <%= f.select :heading_id, budget_heading_select_options(@budget), include_blank: t("admin.budget_investments.edit.select_heading") %> +
+ <%= f.select :heading_id, budget_heading_select_options(@budget), include_blank: t("admin.budget_investments.edit.select_heading") %> +
-

<%= t("admin.budget_investments.edit.classification") %>

- -
+
- <%= f.select(:administrator_id, - @admins.collect{ |a| [a.name_and_email, a.id ] }, - { include_blank: t("admin.budget_investments.edit.undefined") }) %> +

<%= t("admin.budget_investments.edit.classification") %>

+ +
+ <%= f.select(:administrator_id, + @admins.collect{ |a| [a.name_and_email, a.id ] }, + { include_blank: t("admin.budget_investments.edit.undefined") }) %> +
@@ -59,26 +63,27 @@ class: 'js-tag-list' %>
-

Groups

-
- <%= f.label :valuator_ids, "Groups assigned" %> +
+ <%= f.label :valuator_ids, t("admin.budget_investments.edit.user_groups") %> +
    <%= f.collection_check_boxes :valuator_group_ids, @valuator_groups, :id, :name do |group| %> - - <%= group.label(title: group.object.name) { group.check_box + truncate(group.object.name, length: 60) } %> +
  • <%= group.label(title: group.object.name) { group.check_box + truncate(group.object.name, length: 60) } %>
  • <% end %> +
- -

Valuators

-
- <%= f.label :valuator_ids, t("admin.budget_investments.edit.assigned_valuators") %> - <%= f.collection_check_boxes :valuator_ids, @valuators, :id, :email do |b| %> - <%= b.label(title: valuator_label(b.object)) { b.check_box + truncate(b.object.description_or_email, length: 60) } %> - <% end %> +
+
+ <%= f.label :valuator_ids, t("admin.budget_investments.edit.assigned_valuators") %> +
    + <%= f.collection_check_boxes :valuator_ids, @valuators, :id, :email do |b| %> +
  • <%= b.label(title: valuator_label(b.object)) { b.check_box + truncate(b.object.description_or_email, length: 60) } %>
  • + <% end %> +
-
+
<% if @investment.incompatible? || @investment.winner? %>

<%= t("admin.budget_investments.edit.compatibility") %>

@@ -97,7 +102,7 @@
-
+
<%= f.submit(class: "button", value: t("admin.budget_investments.edit.submit_button")) %>
<% end %> diff --git a/app/views/admin/budget_investments/show.html.erb b/app/views/admin/budget_investments/show.html.erb index 8f11333b4..d7f905080 100644 --- a/app/views/admin/budget_investments/show.html.erb +++ b/app/views/admin/budget_investments/show.html.erb @@ -23,7 +23,7 @@

- Valuator Groups: + <%= t("admin.budget_investments.show.valuator_groups") %>: <% if @investment.valuator_groups.any? %> <%= @investment.valuator_groups.collect(&:name).join(', ') %> <% else %> diff --git a/app/views/admin/valuator_groups/_group.html.erb b/app/views/admin/valuator_groups/_group.html.erb index e47de79da..2b2df99f9 100644 --- a/app/views/admin/valuator_groups/_group.html.erb +++ b/app/views/admin/valuator_groups/_group.html.erb @@ -1,18 +1,17 @@ -

- Name: <%= group.name %> -
+ + + <%= link_to group.name, admin_valuator_group_path(group) %> + + + + + + <%= link_to t("admin.actions.delete"), + admin_valuator_group_path(group), + method: :delete, class: "button hollow alert" %> -
- Members: -
- -
- Edit: - <%= link_to "Edit", edit_admin_valuator_group_path(group) %> -
- -
- Destoy: - <%= link_to "Destroy", admin_valuator_group_path(group), method: :delete %> -
-
\ No newline at end of file + <%= link_to t("admin.actions.edit"), + edit_admin_valuator_group_path(group), + class: "button hollow" %> + + diff --git a/app/views/admin/valuator_groups/edit.html.erb b/app/views/admin/valuator_groups/edit.html.erb index 5e0d135c5..fe57117b6 100644 --- a/app/views/admin/valuator_groups/edit.html.erb +++ b/app/views/admin/valuator_groups/edit.html.erb @@ -1,4 +1,9 @@ -<%= form_for [:admin, @group] do |f| %> - <%= f.text_field :name %> - <%= f.submit %> -<% end %> \ No newline at end of file +<%= back_link_to admin_valuator_groups_path %> + +
+ <%= form_for [:admin, @group] do |f| %> + <%= f.label :name, t("admin.valuator_groups.form.name") %> + <%= f.text_field :name, label: false %> + <%= f.submit t("admin.valuator_groups.form.edit"), class: "button success" %> + <% end %> +
\ No newline at end of file diff --git a/app/views/admin/valuator_groups/index.html.erb b/app/views/admin/valuator_groups/index.html.erb index b92987c08..358fa0bc1 100644 --- a/app/views/admin/valuator_groups/index.html.erb +++ b/app/views/admin/valuator_groups/index.html.erb @@ -1,4 +1,23 @@ -<%= render partial: 'group', collection: @groups %> +

<%= t("admin.valuator_groups.index.title") %>

-There are <%= @groups.count %> groups of users -<%= link_to "Nuevo", new_admin_valuator_group_path %> \ No newline at end of file +<%= link_to t("admin.valuator_groups.index.new"), new_admin_valuator_group_path, class: "button float-right" %> + +<% if @groups.any? %> +

There are <%= @groups.count %> groups of users

+ + + + + + + + + <%= render partial: 'group', collection: @groups %> + +
<%= t("admin.valuator_groups.index.name") %><%= t("admin.valuator_groups.index.members") %><%= t("admin.shared.actions") %>
+ +<% else %> +
+ <%= t("admin.valuator_groups.index.no_groups") %> +
+<% end %> diff --git a/app/views/admin/valuator_groups/new.html.erb b/app/views/admin/valuator_groups/new.html.erb index 917cb9760..d79f22d85 100644 --- a/app/views/admin/valuator_groups/new.html.erb +++ b/app/views/admin/valuator_groups/new.html.erb @@ -1,6 +1,9 @@ -<%= form_for [:admin, @group] do |f| %> - <%= f.text_field :name %> - <%= f.submit %> -<% end %> +<%= back_link_to admin_valuator_groups_path %> -<%= link_to "Go back", admin_valuator_groups_path %> \ No newline at end of file +
+ <%= form_for [:admin, @group] do |f| %> + <%= f.label :name, t("admin.valuator_groups.form.name") %> + <%= f.text_field :name, label: false %> + <%= f.submit t("admin.valuator_groups.form.new"), class: "button success" %> + <% end %> +
diff --git a/app/views/admin/valuator_groups/show.html.erb b/app/views/admin/valuator_groups/show.html.erb index e4151040c..d8dd07843 100644 --- a/app/views/admin/valuator_groups/show.html.erb +++ b/app/views/admin/valuator_groups/show.html.erb @@ -1,4 +1,5 @@ -Hey there I'm group <%= @group.name %> +<%= back_link_to admin_valuator_groups_path %> -
-<%= link_to "Ver todos los grupos", admin_valuator_groups_path %> +

<%= t("admin.valuator_groups.show.title", group: @group.name) %>

+ + diff --git a/app/views/admin/valuators/edit.html.erb b/app/views/admin/valuators/edit.html.erb index 2915114e6..89b583d85 100644 --- a/app/views/admin/valuators/edit.html.erb +++ b/app/views/admin/valuators/edit.html.erb @@ -1,9 +1,20 @@ -<%= form_for [:admin, @valuator] do |f| %> - <%= f.text_field :description %> - <%= f.select :valuator_group_id, - @valuator_groups.map {|group| [group.name, group.id] }, - { include_blank: true } %> - <%= f.submit %> -<% end %> +<%= back_link_to admin_valuators_path %> -<%= link_to "Go back", admin_valuator_path(@valuator) %> \ No newline at end of file +

<%= t("admin.valuators.form.edit_title") %>

+ +
+ <%= @valuator.name %>
+ <%= @valuator.email %> +
+ +
+ <%= form_for [:admin, @valuator] do |f| %> + <%= f.text_field :description %> +
+ <%= f.select :valuator_group_id, + @valuator_groups.map {|group| [group.name, group.id] }, + { include_blank: true } %> +
+ <%= f.submit t("admin.valuators.form.update"), class: "button success" %> + <% end %> +
diff --git a/app/views/admin/valuators/index.html.erb b/app/views/admin/valuators/index.html.erb index 15cc66235..902067588 100644 --- a/app/views/admin/valuators/index.html.erb +++ b/app/views/admin/valuators/index.html.erb @@ -1,9 +1,9 @@ -

<%= t("admin.valuators.index.title") %>

+

<%= t("admin.valuators.index.title") %>

+ +<%= link_to t("admin.valuators.index.valuator_groups"), admin_valuator_groups_path, class: "button hollow float-right" %> <%= render "admin/shared/user_search", url: search_admin_valuators_path %> -<%= link_to "Grupos de evaluadores", admin_valuator_groups_path %> -
<% if @valuators.any? %>

<%= page_entries_info @valuators %>

@@ -13,13 +13,13 @@ <%= t("admin.valuators.index.name") %> <%= t("admin.valuators.index.email") %> <%= t("admin.valuators.index.description") %> - Grupo + <%= t("admin.valuators.index.group") %> <%= t("admin.actions.actions") %> <% @valuators.each do |valuator| %> - <%= valuator.name %> + <%= link_to valuator.name, admin_valuator_path(valuator) %> <%= valuator.email %> <% if valuator.description.present? %> @@ -29,16 +29,20 @@ <% end %> - <%= valuator.valuator_group.try(:name) %> + <% if valuator.valuator_group.present? %> + <%= valuator.valuator_group.try(:name) %> + <% else %> + <%= t("admin.valuators.index.no_group") %> + <% end %> - <%= link_to "Edit", + <%= link_to t("admin.actions.edit"), edit_admin_valuator_path(valuator), - class: "button hollow expanded" %> + class: "button hollow" %> <%= link_to t("admin.valuators.valuator.delete"), admin_valuator_path(valuator), method: :delete, - class: "button hollow alert expanded" %> + class: "button hollow alert" %> <% end %> diff --git a/app/views/admin/valuators/show.html.erb b/app/views/admin/valuators/show.html.erb index eff8fad2a..f1768c42f 100644 --- a/app/views/admin/valuators/show.html.erb +++ b/app/views/admin/valuators/show.html.erb @@ -1,7 +1,30 @@ -
Name: <%= @valuator.name %>
-
Description <%= @valuator.description %>
-
Email: <%= @valuator.email %>
-
Group: <%= @valuator.valuator_group.try(:name) %>
+<%= back_link_to admin_valuators_path %> -<%= link_to "See all evaluators", admin_valuators_path %> -<%= link_to "Edit", edit_admin_valuator_path(@valuator) %> \ No newline at end of file +<%= link_to t("admin.actions.edit"), edit_admin_valuator_path(@valuator), class: "button hollow float-right" %> + +
+ +

<%= @valuator.name %>

+ +
+

+ <%= t("admin.valuators.show.email") %>
+ <%= @valuator.email %> +

+

+ <%= t("admin.valuators.show.description") %>
+ <% if @valuator.description.present? %> + <%= @valuator.description %> + <% else %> + <%= t("admin.valuators.show.no_description") %> + <% end %> +

+

+ <%= t("admin.valuators.show.group") %>
+ <% if @valuator.valuator_group.present? %> + <%= @valuator.valuator_group.try(:name) %> + <% else %> + <%= t("admin.valuators.show.no_group") %> + <% end %> +

+
diff --git a/config/locales/en/admin.yml b/config/locales/en/admin.yml index 97d00be77..2929db58a 100644 --- a/config/locales/en/admin.yml +++ b/config/locales/en/admin.yml @@ -13,6 +13,7 @@ en: unmark_featured: Unmark featured edit: Edit configure: Configure + delete: Delete banners: index: title: Banners @@ -176,7 +177,6 @@ en: undecided: "Undecided" selected: "Selected" select: "Select" - download_current_selection: "Download current selection" table_id: "ID" table_title: "Title" table_supports: "Supports" @@ -223,6 +223,7 @@ en: documents: "Documents" see_documents: "See documents (%{count})" no_documents: "Without documents" + valuator_groups: "Valuator Groups" edit: classification: Classification compatibility: Compatibility @@ -236,6 +237,7 @@ en: tags: Tags tags_placeholder: "Write the tags you want separated by commas (,)" undefined: Undefined + user_groups: "Groups" search_unfeasible: Search unfeasible milestones: index: @@ -581,6 +583,9 @@ en: description: Description no_description: No description no_valuators: There are no valuators. + valuator_groups: "Valuator Groups" + group: "Group" + no_group: "No group" valuator: description_placeholder: 'Description (optional)' add: Add to valuators @@ -596,6 +601,29 @@ en: in_evaluation_count: In evaluation total_count: Total cost: Cost + form: + edit_title: "Valuators: Edit valuator" + update: "Update valuator" + updated: "Valuator updated successfully" + show: + description: "Description" + email: "Email" + group: "Group" + no_description: "Without description" + no_group: "Without group" + valuator_groups: + index: + title: "Valuator groups" + new: "Create valuators group" + name: "Name" + members: "Members" + no_groups: "There are no valuator groups" + show: + title: "Valuators group: %{group}" + form: + name: "Group name" + new: "Create valuators group" + edit: "Save valuators group" poll_officers: index: title: Poll officers diff --git a/config/locales/es/admin.yml b/config/locales/es/admin.yml index af2ee9511..0502e2bf3 100644 --- a/config/locales/es/admin.yml +++ b/config/locales/es/admin.yml @@ -13,6 +13,7 @@ es: unmark_featured: Quitar destacado edit: Editar configure: Configurar + delete: Borrar banners: index: title: Banners @@ -222,6 +223,7 @@ es: documents: "Documentos" see_documents: "Ver documentos (%{count})" no_documents: "Sin documentos" + valuator_groups: "Grupos de evaluadores" edit: classification: Clasificación compatibility: Compatibilidad @@ -235,6 +237,7 @@ es: tags: Etiquetas tags_placeholder: "Escribe las etiquetas que desees separadas por comas (,)" undefined: Sin definir + user_groups: "Grupos" search_unfeasible: Buscar inviables milestones: index: @@ -580,6 +583,9 @@ es: description: Descripción no_description: Sin descripción no_valuators: No hay evaluadores. + valuator_groups: "Grupo de evaluadores" + group: "Grupo" + no_group: "Sin grupo" valuator: description_placeholder: 'Descripción (opcional)' add: Añadir como evaluador @@ -595,6 +601,29 @@ es: in_evaluation_count: En evaluación total_count: Total cost: Coste total + form: + edit_title: "Evaluadores: Editar evaluador" + update: "Actualizar evaluador" + updated: "Evaluador actualizado correctamente" + show: + description: "Descripción" + email: "Email" + group: "Grupo" + no_description: "Sin descripción" + no_group: "Sin grupo" + valuator_groups: + index: + title: "Grupos de evaluadores" + new: "Crear grupo de evaluadores" + name: "Nombre" + members: "Miembros" + no_groups: "No hay grupos de evaluadores" + show: + title: "Grupo de evaluadores: %{group}" + form: + name: "Nombre del grupo" + new: "Crear grupo de evaluadores" + edit: "Guardar grupo de evaluadores" poll_officers: index: title: Presidentes de mesa