From 13409c2e359ec142f1465000f033834dfb5e5b72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mar=C3=ADa=20Checa?= Date: Fri, 14 Jul 2017 15:35:50 +0200 Subject: [PATCH] Performance minor changes in `CensusCaller` and `LocalCensus` --- lib/census_caller.rb | 2 ++ lib/local_census.rb | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/census_caller.rb b/lib/census_caller.rb index 21e69227e..d104b03c8 100644 --- a/lib/census_caller.rb +++ b/lib/census_caller.rb @@ -3,5 +3,7 @@ class CensusCaller def call(document_type, document_number) response = CensusApi.new.call(document_type, document_number) response = LocalCensus.new.call(document_type, document_number) unless response.valid? + + response end end diff --git a/lib/local_census.rb b/lib/local_census.rb index 6dce4df72..64c1a4052 100644 --- a/lib/local_census.rb +++ b/lib/local_census.rb @@ -16,9 +16,7 @@ class LocalCensus end def valid? - @body.valid? - rescue NoMethodError - false + @body.present? ? !@body.attributes.values.include?("" || nil) : false end def date_of_birth