diff --git a/app/models/poll.rb b/app/models/poll.rb index f08f9bdcd..27125d8a1 100644 --- a/app/models/poll.rb +++ b/app/models/poll.rb @@ -90,8 +90,4 @@ class Poll < ActiveRecord::Base end end - def shifts_in_booth(booth_id) - officer_assignments.where(booth_assignment_id: booth_assignments.where(booth_id: booth_id).pluck(:id)).pluck(:officer_id).uniq - end - end diff --git a/app/models/poll/booth_assignment.rb b/app/models/poll/booth_assignment.rb index a1d0c0d39..81759ee0f 100644 --- a/app/models/poll/booth_assignment.rb +++ b/app/models/poll/booth_assignment.rb @@ -3,23 +3,26 @@ class Poll belongs_to :booth belongs_to :poll + before_destroy :destroy_poll_shifts, only: :destroy + has_many :officer_assignments, class_name: "Poll::OfficerAssignment", dependent: :destroy has_many :officers, through: :officer_assignments has_many :voters has_many :partial_results has_many :recounts - before_destroy :destroy_poll_shifts - - def has_shifts? - + def shifts? + shifts.empty? ? false : true end private + def shifts + Poll::Shift.where(booth_id: booth_id, officer_id: officer_assignments.pluck(:officer_id), date: officer_assignments.pluck(:date)) + end + def destroy_poll_shifts -# officers = poll.officers_in_booth(booth.id) -# Poll::Shift.where(officer_id: officers, booth_id: booth.id) + shifts.destroy_all end end end diff --git a/app/views/admin/poll/booth_assignments/_booth_assignment.html.erb b/app/views/admin/poll/booth_assignments/_booth_assignment.html.erb index b1ab3885e..b3b711f9f 100644 --- a/app/views/admin/poll/booth_assignments/_booth_assignment.html.erb +++ b/app/views/admin/poll/booth_assignments/_booth_assignment.html.erb @@ -15,7 +15,7 @@ remote: true, title: t("admin.booth_assignments.manage.actions.unassign"), class: "button hollow alert #{@poll.expired? ? 'disabled' : ''}", - data: (booth_assignment.has_shifts? ? {confirm: "Are you sure?"} : nil) %> + data: (booth_assignment.shifts? ? {confirm: "#{t("admin.poll_booth_assignments.alert.shifts")}"} : nil) %> <% else %>