From 3a18ba1d4f7df24806d6e2a0984d314860cd1bca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 20 Mar 2024 00:00:21 +0100 Subject: [PATCH 1/2] Bump autoprefixer-rails from 8.2.0 to 10.2.5.1 We're upgrading to this version in order because it's the first version that works with our current version of execjs when running the `autoprefixer:info` task. Since it's been such a long time since the last time we upgraded autoprefixer-rails (version 8.2.0, which is the version we were using, was released on March 2018), and we're getting a warning when compiling the assets with the latest version, we're going to do it gradually; version 10.2.5.1 was released on May 2021, so it also seems like a reasonable middlepoint. Note we're moving the `browserlist` file to `.browserlistrc` because that's the expected locations in new versions of autoprefixer-rails. Also note that we're changing this file so we support browsers released in the last 7 years, so we still support more or less the same browsers we supported before this change (about 98% of the browsers out there). We might reduce it to 5 years in the future. Bumps [autoprefixer-rails](https://github.com/ai/autoprefixer-rails) from 8.2.0 to 10.2.5.1 - [Changelog](https://github.com/ai/autoprefixer-rails/blob/master/CHANGELOG.md) - [Commits](https://github.com/ai/autoprefixer-rails/compare/8.2.0...10.2.5.1 --- Gemfile | 2 +- Gemfile.lock | 6 +++--- app/assets/stylesheets/{browserslist => .browserslistrc} | 1 + 3 files changed, 5 insertions(+), 4 deletions(-) rename app/assets/stylesheets/{browserslist => .browserslistrc} (78%) diff --git a/Gemfile b/Gemfile index 304689faf..857c7e7b3 100644 --- a/Gemfile +++ b/Gemfile @@ -8,7 +8,7 @@ gem "ahoy_matey", "~> 5.0.2" gem "airbrake", "~> 13.0.4" gem "ancestry", "~> 4.3.3" gem "audited", "~> 5.4.3" -gem "autoprefixer-rails", "~> 8.2.0" +gem "autoprefixer-rails", "~> 10.2.5.1" gem "bing_translator", "~> 6.2.0" gem "cancancan", "~> 3.5.0" gem "caxlsx", "~> 4.1.0" diff --git a/Gemfile.lock b/Gemfile.lock index c7f0dfef3..54e7cdaa4 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -87,8 +87,8 @@ GEM audited (5.4.3) activerecord (>= 5.0, < 7.2) request_store (~> 1.2) - autoprefixer-rails (8.2.0) - execjs + autoprefixer-rails (10.2.5.1) + execjs (> 0) base64 (0.1.1) bcrypt (3.1.20) better_html (2.0.2) @@ -689,7 +689,7 @@ DEPENDENCIES airbrake (~> 13.0.4) ancestry (~> 4.3.3) audited (~> 5.4.3) - autoprefixer-rails (~> 8.2.0) + autoprefixer-rails (~> 10.2.5.1) bing_translator (~> 6.2.0) bullet (~> 7.1.6) byebug (~> 11.1.3) diff --git a/app/assets/stylesheets/browserslist b/app/assets/stylesheets/.browserslistrc similarity index 78% rename from app/assets/stylesheets/browserslist rename to app/assets/stylesheets/.browserslistrc index 6019618a9..c637e0cbc 100644 --- a/app/assets/stylesheets/browserslist +++ b/app/assets/stylesheets/.browserslistrc @@ -1,4 +1,5 @@ last 2 versions +last 7 years ie >= 9 Android >= 2.3 ios >= 7 From fba8b7307569631bb5233bdfbe8bbd95d17e07cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 20 Mar 2024 00:24:55 +0100 Subject: [PATCH 2/2] Remove support for very old browsers in autoprefixer These browsers are very old, we don't support them, and, combined, their usage is about 0.1%. We're still supporting IE 11 through the "last 1 version" option and many versions of Android and ios through the "last 7 years" option. Thanks to this change, we no longer generate prefixes in flexbox properties, making debugging in the browser easier. There are no significant differences in the size of the compiled CSS in production environments, though (with these changes, the file is about 2% smaller). --- app/assets/stylesheets/.browserslistrc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/assets/stylesheets/.browserslistrc b/app/assets/stylesheets/.browserslistrc index c637e0cbc..63bd8b23d 100644 --- a/app/assets/stylesheets/.browserslistrc +++ b/app/assets/stylesheets/.browserslistrc @@ -1,5 +1,2 @@ -last 2 versions +last 1 version last 7 years -ie >= 9 -Android >= 2.3 -ios >= 7