Add and apply Capybara/RSpec/HaveSelector rule
This rule was added in rubocop-capybara 2.19.0. We were following it about 85% of the time. Now we won't have to check both have_css and have_selector when searching the code.
This commit is contained in:
@@ -41,7 +41,7 @@ describe "Commenting legislation questions" do
|
||||
expect(page).to have_link "Go back to #{question.title}", href: href
|
||||
|
||||
within ".comment", text: "Parent" do
|
||||
expect(page).to have_selector(".comment", count: 2)
|
||||
expect(page).to have_css ".comment", count: 2
|
||||
end
|
||||
end
|
||||
|
||||
@@ -268,7 +268,7 @@ describe "Commenting legislation questions" do
|
||||
expect(page).to have_content "It will be done next week."
|
||||
end
|
||||
|
||||
expect(page).not_to have_selector("#js-comment-form-comment_#{comment.id}")
|
||||
expect(page).not_to have_css "#js-comment-form-comment_#{comment.id}"
|
||||
end
|
||||
|
||||
scenario "Reply update parent comment responses count" do
|
||||
@@ -397,7 +397,7 @@ describe "Commenting legislation questions" do
|
||||
expect(page).to have_css "img.moderator-avatar"
|
||||
end
|
||||
|
||||
expect(page).not_to have_selector("#js-comment-form-comment_#{comment.id}")
|
||||
expect(page).not_to have_css "#js-comment-form-comment_#{comment.id}"
|
||||
end
|
||||
|
||||
scenario "can not comment as an administrator" do
|
||||
@@ -453,7 +453,7 @@ describe "Commenting legislation questions" do
|
||||
expect(page).to have_css "img.admin-avatar"
|
||||
end
|
||||
|
||||
expect(page).not_to have_selector("#js-comment-form-comment_#{comment.id}")
|
||||
expect(page).not_to have_css "#js-comment-form-comment_#{comment.id}"
|
||||
end
|
||||
|
||||
scenario "can not comment as a moderator", :admin do
|
||||
|
||||
Reference in New Issue
Block a user