consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add and apply Capybara/RSpec/HaveSelector rule

Browse Source 
This rule was added in rubocop-capybara 2.19.0. We were following it
about 85% of the time.

Now we won't have to check both have_css and have_selector when
searching the code.
This commit is contained in:
Javi Martín
2023-10-03 18:35:51 +02:00
parent 83f3cbc143
commit 0cec581ec0
53 changed files with 206 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/system/admin/site_customization/documents_spec.rb
View File

@@ -39,7 +39,7 @@ describe "Documents", :admin do
visit admin_site_customization_documents_path
expect(page).to have_selector("#documents .document-row", count: per_page)
expect(page).to have_css "#documents .document-row", count: per_page
within("ul.pagination") do
expect(page).to have_content("1")
@@ -48,7 +48,7 @@ describe "Documents", :admin do
click_link "Next", exact: false
end
expect(page).to have_selector("#documents .document-row", count: 2)
expect(page).to have_css "#documents .document-row", count: 2
end
scenario "Create" do

4
spec/system/admin/site_customization/pages_spec.rb
View File

@@ -69,8 +69,8 @@ describe "Admin custom pages", :admin do
within("tr", text: "An example custom page") { click_link "Edit" }
expect(page).to have_selector("h2", text: "An example custom page")
expect(page).to have_selector("input[value='custom-example-page']")
expect(page).to have_css "h2", text: "An example custom page"
expect(page).to have_css "input[value='custom-example-page']"
fill_in "Title", with: "Another example custom page"
fill_in "site_customization_page_slug", with: "another-custom-example-page"