Add and apply Capybara/RSpec/HaveSelector rule

This rule was added in rubocop-capybara 2.19.0. We were following it
about 85% of the time.

Now we won't have to check both have_css and have_selector when
searching the code.
This commit is contained in:
Javi Martín
2023-10-03 18:35:51 +02:00
parent 83f3cbc143
commit 0cec581ec0
53 changed files with 206 additions and 203 deletions

View File

@@ -222,10 +222,10 @@ describe "Admin booths assignments", :admin do
expect(page).to have_content "10"
end
expect(page).not_to have_selector "#total_system"
expect(page).not_to have_css "#total_system"
end
expect(page).not_to have_selector "#recounts_list"
expect(page).not_to have_css "#recounts_list"
end
scenario "Results for a booth assignment" do

View File

@@ -327,11 +327,11 @@ describe "Admin polls", :admin do
expect(page).to have_content("10")
end
expect(page).not_to have_selector "#total_system"
expect(page).not_to have_css "#total_system"
end
expect(page).to have_selector "#poll_booth_assignment_#{booth_assignment.id}_recounts"
expect(page).not_to have_selector "#poll_booth_assignment_#{booth_assignment.id}_system"
expect(page).to have_css "#poll_booth_assignment_#{booth_assignment.id}_recounts"
expect(page).not_to have_css "#poll_booth_assignment_#{booth_assignment.id}_system"
end
end
end

View File

@@ -51,8 +51,8 @@ describe "Admin poll questions", :admin do
click_link "Create question"
expect(page).to have_content("Create question to poll Movies")
expect(page).to have_selector("input[id='poll_question_poll_id'][value='#{poll.id}']",
visible: :hidden)
expect(page).to have_css "input[id='poll_question_poll_id'][value='#{poll.id}']",
visible: :hidden
fill_in "Question", with: "Star Wars: Episode IV - A New Hope"
click_button "Save"