consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add and apply Capybara/RSpec/HaveSelector rule

Browse Source 
This rule was added in rubocop-capybara 2.19.0. We were following it
about 85% of the time.

Now we won't have to check both have_css and have_selector when
searching the code.
This commit is contained in:
Javi Martín
2023-10-03 18:35:51 +02:00
parent 83f3cbc143
commit 0cec581ec0
53 changed files with 206 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spec/system/account_spec.rb
View File

@@ -14,8 +14,8 @@ describe "Account" do
expect(page).to have_current_path(account_path, ignore_query: true)
expect(page).to have_selector("input[value='Manuela Colau']")
expect(page).to have_selector(avatar("Manuela Colau"), count: 1)
expect(page).to have_css "input[value='Manuela Colau']"
expect(page).to have_css avatar("Manuela Colau"), count: 1
end
scenario "Show organization" do
@@ -23,10 +23,10 @@ describe "Account" do
visit account_path
expect(page).to have_selector("input[value='Manuela Corp']")
expect(page).not_to have_selector("input[value='Manuela Colau']")
expect(page).to have_css "input[value='Manuela Corp']"
expect(page).not_to have_css "input[value='Manuela Colau']"
expect(page).to have_selector(avatar("Manuela Corp"), count: 1)
expect(page).to have_css avatar("Manuela Corp"), count: 1
end
scenario "Edit" do
@@ -43,7 +43,7 @@ describe "Account" do
visit account_path
expect(page).to have_selector("input[value='Larry Bird']")
expect(page).to have_css "input[value='Larry Bird']"
expect(find("#account_email_on_comment")).to be_checked
expect(find("#account_email_on_comment_reply")).to be_checked
expect(find("#account_email_digest")).not_to be_checked
@@ -81,7 +81,7 @@ describe "Account" do
visit account_path
click_link "Change my login details"
expect(page).to have_selector("input[value='new_user_email@example.com']")
expect(page).to have_css "input[value='new_user_email@example.com']"
end
scenario "Edit Organization" do
@@ -98,7 +98,7 @@ describe "Account" do
visit account_path
expect(page).to have_selector("input[value='Google']")
expect(page).to have_css "input[value='Google']"
expect(find("#account_email_on_comment")).to be_checked
expect(find("#account_email_on_comment_reply")).to be_checked
end