consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Open proposals dashboard links in the same window

Browse Source 
Out of the usability issues I've experienced when using Consul
Democracy, the biggest one has arguably been the fact that the link to
edit a proposal opens in a new tab. I guess the reasoning behind it is
that the page to edit a proposal is not part of the proposals dashboard,
but what the hell! Imagine if every link to edit something opened in a
new tab...

So we're reducing the impact of this nonsense by opening most dashboard
links in the same window; for now, we're still opening in a new window
links to download files and links that might point to external websites.
We'll address those ones in the future.
This commit is contained in:
Javi Martín
2023-10-05 21:21:48 +02:00
parent ef7486ddc6
commit 0c14feee19
10 changed files with 23 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/layouts/dashboard/_proposal_header.html.erb
View File

@@ -1,5 +1,5 @@
<h3 class="proposal-title">
<%= link_to proposal.title, proposal, target: "_blank" %>
<%= link_to proposal.title, proposal %>
</h3>
<% if proposal.retired? %>

4
app/views/layouts/dashboard/_proposal_totals.html.erb
View File

@@ -47,9 +47,9 @@
<div class="small-12 column">
<div class="proposal-link">
<% if proposal.draft? %>
<%= link_to t("layouts.dashboard.proposal_totals.preview_proposal"), proposal_path(proposal), class: "button success expanded", target: "_blank" %>
<%= link_to t("layouts.dashboard.proposal_totals.preview_proposal"), proposal_path(proposal), class: "button success expanded" %>
<% else %>
<%= link_to t("layouts.dashboard.proposal_totals.show_proposal"), proposal_path(proposal), class: "button success expanded", target: "_blank" %>
<%= link_to t("layouts.dashboard.proposal_totals.show_proposal"), proposal_path(proposal), class: "button success expanded" %>
<% end %>
</div>
</div>