Add and apply Layout/DotPosition rule

Since IRB has improved its support for multiline, the main argument
towars using a trailing dot no longer affects most people.

It still affects me, though, since I use Pry :), but I agree
leading dots are more readable, so I'm enabling the rule anyway.
This commit is contained in:
Javi Martín
2023-07-01 14:53:02 +02:00
parent fd71ae5333
commit 09c63e354c
15 changed files with 72 additions and 69 deletions

View File

@@ -4,10 +4,10 @@ class Admin::Poll::OfficerAssignmentsController < Admin::Poll::BaseController
before_action :load_booth_assignment, only: [:create]
def index
@officers = ::Poll::Officer.
includes(:user).
order("users.username").
where(
@officers = ::Poll::Officer
.includes(:user)
.order("users.username")
.where(
id: @poll.officer_assignments.select(:officer_id).distinct.map(&:officer_id)
).page(params[:page]).per(50)
end
@@ -15,11 +15,11 @@ class Admin::Poll::OfficerAssignmentsController < Admin::Poll::BaseController
def by_officer
@poll = ::Poll.includes(:booths).find(params[:poll_id])
@officer = ::Poll::Officer.includes(:user).find(officer_assignment_params[:officer_id])
@officer_assignments = ::Poll::OfficerAssignment.
joins(:booth_assignment).
includes(:recounts, booth_assignment: :booth).
by_officer_and_poll(@officer.id, @poll.id).
order(:date)
@officer_assignments = ::Poll::OfficerAssignment
.joins(:booth_assignment)
.includes(:recounts, booth_assignment: :booth)
.by_officer_and_poll(@officer.id, @poll.id)
.order(:date)
end
def search_officers