From 0824b64d4b2bb386bdd9a93dc55bc474a3474bdd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Fri, 11 Sep 2020 01:11:59 +0200
Subject: [PATCH] Simplify display rules for show-children icon

We were using `display: inline` assuming that's the way elements will be
displayed by default when shown. However, those elements could be
displayed in a different way (inline-flex, for instance). So we avoid
any possible conflicts by using the `display: none` rule when we want to
hide the elements.

Besides, the code is now symmetrical and IMHO easier to follow.
---
 app/assets/stylesheets/layout.scss | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss
index d33e4ffa6..2d541242f 100644
--- a/app/assets/stylesheets/layout.scss
+++ b/app/assets/stylesheets/layout.scss
@@ -2114,7 +2114,6 @@ table {
   .responses-count {
     .show-children {
       @include has-fa-icon(plus-square, regular);
-      display: none;
     }
 
     .collapse-children {
@@ -2132,9 +2131,12 @@ table {
       .collapse-children {
         display: none;
       }
+    }
+
+    &:not(.collapsed) {
 
       .show-children {
-        display: inline;
+        display: none;
       }
     }
   }