From 0505028d77c3c764fe6ae89f0329cdea42f66129 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 15 Oct 2018 17:25:24 +0200 Subject: [PATCH] Extract method in translatable builder This way we fix the rubocop warning for line too long and make the code a bit easier to read. --- app/helpers/translatable_form_helper.rb | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/helpers/translatable_form_helper.rb b/app/helpers/translatable_form_helper.rb index 0232131fb..f4b79e0f5 100644 --- a/app/helpers/translatable_form_helper.rb +++ b/app/helpers/translatable_form_helper.rb @@ -9,7 +9,7 @@ module TranslatableFormHelper def translatable_fields(&block) @object.globalize_locales.map do |locale| Globalize.with_locale(locale) do - fields_for(:translations, translation_for(locale), builder: TranslationsFieldsBuilder) do |translations_form| + fields_for_translation(translation_for(locale)) do |translations_form| @template.content_tag :div, translations_options(translations_form.object, locale) do @template.concat translations_form.hidden_field( :_destroy, @@ -27,6 +27,12 @@ module TranslatableFormHelper private + def fields_for_translation(translation, &block) + fields_for(:translations, translation, builder: TranslationsFieldsBuilder) do |f| + yield f + end + end + def translation_for(locale) existing_translation_for(locale) || new_translation_for(locale) end