Merge pull request #2712 from javierv/2520_and_2521-fix_flaky_results_specs

Fix flaky specs: Officing Results Add/Edit results

spec/features/officing/residence_spec.rb

@@ -3,6 +3,14 @@ require 'rails_helper'
 feature 'Residence' do
   let(:officer) { create(:poll_officer) }
 
+  background do
+    travel_to Time.now # TODO: use `freeze_time` after migrating to Rails 5.
+  end
+
+  after do
+    travel_back
+  end
+
   feature "Officers without assignments" do
 
     scenario "Can not access residence verification" do

spec/features/officing/results_spec.rb

@@ -3,6 +3,7 @@ require 'rails_helper'
 feature 'Officing Results' do
 
   background do
+    travel_to Time.now # TODO: use `freeze_time` after migrating to Rails 5.
     @poll_officer = create(:poll_officer)
     @officer_assignment = create(:poll_officer_assignment, :final, officer: @poll_officer)
     @poll = @officer_assignment.booth_assignment.poll
@@ -17,6 +18,10 @@ feature 'Officing Results' do
     login_as(@poll_officer.user)
   end
 
+  after do
+    travel_back
+  end
+
   scenario 'Only polls where user is officer for results are accessible' do
     regular_officer_assignment_1 = create(:poll_officer_assignment, officer: @poll_officer)
     regular_officer_assignment_2 = create(:poll_officer_assignment, officer: @poll_officer)