Sign in manager after setting up test data

We've got quite a messy hack to sign in managers: they need to visit a
specific URL (management root path).

That means tests signing in managers start the browser to sign them in,
which might cause issues if we setup the database after that.
This commit is contained in:
Javi Martín
2021-04-02 15:20:09 +02:00
parent efbb3bb690
commit 03d0ffd89e
9 changed files with 61 additions and 48 deletions

View File

@@ -1,13 +1,10 @@
require "rails_helper"
describe "DocumentVerifications" do
before do
login_as_manager
end
scenario "Verifying a level 3 user shows an 'already verified' page" do
user = create(:user, :level_three)
login_as_manager
visit management_document_verifications_path
fill_in "document_verification_document_number", with: user.document_number
click_button "Check document"
@@ -18,6 +15,7 @@ describe "DocumentVerifications" do
scenario "Verifying a level 2 user displays the verification form" do
user = create(:user, :level_two)
login_as_manager
visit management_document_verifications_path
fill_in "document_verification_document_number", with: user.document_number
click_button "Check document"
@@ -37,6 +35,7 @@ describe "DocumentVerifications" do
expect_any_instance_of(Verification::Management::Document).to receive(:in_census?).
and_return(false)
login_as_manager
visit management_document_verifications_path
fill_in "document_verification_document_number", with: "inexisting"
click_button "Check document"
@@ -45,6 +44,7 @@ describe "DocumentVerifications" do
end
scenario "Verifying a user which does exists in the census but not in the db redirects allows sending an email" do
login_as_manager
visit management_document_verifications_path
fill_in "document_verification_document_number", with: "12345678Z"
click_button "Check document"
@@ -58,6 +58,7 @@ describe "DocumentVerifications" do
expect_any_instance_of(Verification::Management::Document).to receive(:in_census?).
and_return(false)
login_as_manager
visit management_document_verifications_path
fill_in "document_verification_document_number", with: "12345678Z"
select_date "31-December-1980", from: "document_verification_date_of_birth"
@@ -71,6 +72,7 @@ describe "DocumentVerifications" do
redirects allows sending an email" do
mock_valid_remote_census_response
login_as_manager
visit management_document_verifications_path
fill_in "document_verification_document_number", with: "12345678Z"
select_date "31-December-1980", from: "document_verification_date_of_birth"
@@ -83,6 +85,7 @@ describe "DocumentVerifications" do
end
scenario "Document number is format-standarized" do
login_as_manager
visit management_document_verifications_path
fill_in "document_verification_document_number", with: "12345 - h"
click_button "Check document"
@@ -93,6 +96,7 @@ describe "DocumentVerifications" do
scenario "User age is checked" do
expect_any_instance_of(Verification::Management::Document).to receive(:under_age?).and_return(true)
login_as_manager
visit management_document_verifications_path
fill_in "document_verification_document_number", with: "12345678Z"
click_button "Check document"