consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary html_safe in paths

Browse Source 
Paths are just regular strings with no HTML, so they don't need to be
marked as safe HTML.
This commit is contained in:
Javi Martín
2019-10-01 15:16:45 +02:00
parent 20ca6beb30
commit 031b5aba63
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/admin/legislation/draft_versions_controller.rb
View File

@@ -10,7 +10,7 @@ class Admin::Legislation::DraftVersionsController < Admin::Legislation::BaseCont
def create def create
if @draft_version.save if @draft_version.save
link = legislation_process_draft_version_path(@process, @draft_version).html_safe link = legislation_process_draft_version_path(@process, @draft_version)
notice = t("admin.legislation.draft_versions.create.notice", link: link) notice = t("admin.legislation.draft_versions.create.notice", link: link)
redirect_to admin_legislation_process_draft_versions_path, notice: notice redirect_to admin_legislation_process_draft_versions_path, notice: notice
else else
@@ -21,7 +21,7 @@ class Admin::Legislation::DraftVersionsController < Admin::Legislation::BaseCont
def update def update
if @draft_version.update(draft_version_params) if @draft_version.update(draft_version_params)
link = legislation_process_draft_version_path(@process, @draft_version).html_safe link = legislation_process_draft_version_path(@process, @draft_version)
notice = t("admin.legislation.draft_versions.update.notice", link: link) notice = t("admin.legislation.draft_versions.update.notice", link: link)
edit_path = edit_admin_legislation_process_draft_version_path(@process, @draft_version) edit_path = edit_admin_legislation_process_draft_version_path(@process, @draft_version)
redirect_to edit_path, notice: notice redirect_to edit_path, notice: notice

2
app/controllers/admin/legislation/homepages_controller.rb
View File

@@ -8,7 +8,7 @@ class Admin::Legislation::HomepagesController < Admin::Legislation::BaseControll
def update def update
if @process.update(process_params) if @process.update(process_params)
link = legislation_process_path(@process).html_safe link = legislation_process_path(@process)
redirect_back(fallback_location: (request.referer || root_path), redirect_back(fallback_location: (request.referer || root_path),
notice: t("admin.legislation.processes.update.notice", link: link)) notice: t("admin.legislation.processes.update.notice", link: link))
else else

4
app/controllers/admin/legislation/processes_controller.rb
View File

@@ -23,7 +23,7 @@ class Admin::Legislation::ProcessesController < Admin::Legislation::BaseControll
def create def create
if @process.save if @process.save
link = legislation_process_path(@process).html_safe link = legislation_process_path(@process)
notice = t("admin.legislation.processes.create.notice", link: link) notice = t("admin.legislation.processes.create.notice", link: link)
redirect_to edit_admin_legislation_process_path(@process), notice: notice redirect_to edit_admin_legislation_process_path(@process), notice: notice
else else
@@ -36,7 +36,7 @@ class Admin::Legislation::ProcessesController < Admin::Legislation::BaseControll
if @process.update(process_params) if @process.update(process_params)
set_tag_list set_tag_list
link = legislation_process_path(@process).html_safe link = legislation_process_path(@process)
redirect_back(fallback_location: (request.referer || root_path), redirect_back(fallback_location: (request.referer || root_path),
notice: t("admin.legislation.processes.update.notice", link: link)) notice: t("admin.legislation.processes.update.notice", link: link))
else else

2
app/controllers/admin/legislation/questions_controller.rb
View File

@@ -41,7 +41,7 @@ class Admin::Legislation::QuestionsController < Admin::Legislation::BaseControll
private private
def question_path def question_path
legislation_process_question_path(@process, @question).html_safe legislation_process_question_path(@process, @question)
end end
def question_params def question_params