consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add and apply Style/AccessorGrouping rubocop rule

Browse Source 
This rule was added in Rubocop 0.87.0. We were already grouping
accessors in most places.
This commit is contained in:
Javi Martín
2020-10-10 20:35:30 +02:00
parent e5f4869c02
commit 02ecdf6acc
3 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.rubocop.yml
View File

@@ -368,6 +368,9 @@ Security/JSONLoad:
Security/YAMLLoad: Security/YAMLLoad:
Enabled: true Enabled: true
Style/AccessorGrouping:
Enabled: true
Style/AndOr: Style/AndOr:
Enabled: true Enabled: true

4
app/models/user.rb
View File

@@ -89,9 +89,7 @@ class User < ApplicationRecord
accepts_nested_attributes_for :organization, update_only: true accepts_nested_attributes_for :organization, update_only: true
attr_accessor :skip_password_validation attr_accessor :skip_password_validation, :use_redeemable_code, :login
attr_accessor :use_redeemable_code
attr_accessor :login
scope :administrators, -> { joins(:administrator) } scope :administrators, -> { joins(:administrator) }
scope :moderators, -> { joins(:moderator) } scope :moderators, -> { joins(:moderator) }

4
app/models/verification/management/email.rb
View File

@@ -1,9 +1,7 @@
class Verification::Management::Email class Verification::Management::Email
include ActiveModel::Model include ActiveModel::Model
attr_accessor :document_type attr_accessor :document_type, :document_number, :email
attr_accessor :document_number
attr_accessor :email
validates :document_type, :document_number, :email, presence: true validates :document_type, :document_number, :email, presence: true
validates :email, format: { with: Devise.email_regexp }, allow_blank: true validates :email, format: { with: Devise.email_regexp }, allow_blank: true