consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make action names to block and hide more clear

Browse Source 
The `hide` action was calling the `block` method while the `soft_block`
action was calling the `hide` method.

Combined with the fact that we also have a `block` permission which is
used in `ModerateActions` the logic was hard to follow.
This commit is contained in:
Javi Martín
2021-12-02 03:02:37 +01:00
parent cac24b0159
commit 021fef07b6
18 changed files with 46 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/system/admin/activity_spec.rb
View File

@@ -217,7 +217,7 @@ describe "Admin activity" do
visit proposal_path(proposal)
within("#proposal_#{proposal.id}") do
accept_confirm("Are you sure? Hide author \"#{proposal.author.name}\"") { click_link "Hide author" }
accept_confirm("Are you sure? Block author \"#{proposal.author.name}\"") { click_link "Block author" }
expect(page).to have_current_path(proposals_path)
end

2
spec/system/admin/hidden_comments_spec.rb
View File

@@ -13,7 +13,7 @@ describe "Admin hidden comments", :admin do
visit proposal_path(proposal)
within("#proposal_#{proposal.id}") do
accept_confirm("Are you sure? Hide author \"#{proposal.author.name}\"") { click_link "Hide author" }
accept_confirm("Are you sure? Block author \"#{proposal.author.name}\"") { click_link "Block author" }
end
expect(page).to have_current_path proposals_path