consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make action names to block and hide more clear

Browse Source 
The `hide` action was calling the `block` method while the `soft_block`
action was calling the `hide` method.

Combined with the fact that we also have a `block` permission which is
used in `ModerateActions` the logic was hard to follow.
This commit is contained in:
Javi Martín
2021-12-02 03:02:37 +01:00
parent cac24b0159
commit 021fef07b6
18 changed files with 46 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spec/models/abilities/moderator_spec.rb
View File

@@ -90,9 +90,6 @@ describe Abilities::Moderator do
it { should_not be_able_to(:hide, user) }
it { should be_able_to(:hide, other_user) }
it { should_not be_able_to(:soft_block, user) }
it { should be_able_to(:soft_block, other_user) }
it { should_not be_able_to(:block, user) }
it { should be_able_to(:block, other_user) }