From 01c21158c43827dd057fb95bb5eaea0b029140e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 3 Jun 2021 02:48:27 +0200 Subject: [PATCH] Use :only in groups and headings before_action When we've got 6 actions and we use it in 3, IMHO the code is easier to follow if we write the actions where we do use it. --- app/controllers/admin/budget_groups_controller.rb | 2 +- app/controllers/admin/budget_headings_controller.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/admin/budget_groups_controller.rb b/app/controllers/admin/budget_groups_controller.rb index 1a19d5296..0e2b87719 100644 --- a/app/controllers/admin/budget_groups_controller.rb +++ b/app/controllers/admin/budget_groups_controller.rb @@ -4,7 +4,7 @@ class Admin::BudgetGroupsController < Admin::BaseController feature_flag :budgets before_action :load_budget - before_action :load_group, except: [:index, :new, :create] + before_action :load_group, only: [:edit, :update, :destroy] def index @groups = @budget.groups.order(:id) diff --git a/app/controllers/admin/budget_headings_controller.rb b/app/controllers/admin/budget_headings_controller.rb index da701cb7f..6c0f43174 100644 --- a/app/controllers/admin/budget_headings_controller.rb +++ b/app/controllers/admin/budget_headings_controller.rb @@ -5,7 +5,7 @@ class Admin::BudgetHeadingsController < Admin::BaseController before_action :load_budget before_action :load_group - before_action :load_heading, except: [:index, :new, :create] + before_action :load_heading, only: [:edit, :update, :destroy] def index @headings = @group.headings.order(:id)