From 014d29b991addc4c8b0ae9946cb6be9f88bad4ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Fri, 5 Mar 2021 18:49:12 +0100
Subject: [PATCH] Extract method to get a budget phase title

---
 app/components/budgets/phases_component.html.erb          | 2 +-
 app/models/budget.rb                                      | 4 ----
 app/models/budget/phase.rb                                | 8 ++++++--
 app/views/admin/budget_phases/edit.html.erb               | 2 +-
 app/views/admin/budgets/_form.html.erb                    | 2 +-
 app/views/admin/budgets/index.html.erb                    | 2 +-
 app/views/budgets/index.html.erb                          | 2 +-
 app/views/budgets/show.html.erb                           | 2 +-
 app/views/management/budgets/create_investments.html.erb  | 2 +-
 app/views/management/budgets/print_investments.html.erb   | 2 +-
 app/views/management/budgets/support_investments.html.erb | 2 +-
 app/views/valuation/budgets/index.html.erb                | 2 +-
 12 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/app/components/budgets/phases_component.html.erb b/app/components/budgets/phases_component.html.erb
index fa0db2ffa..61ea75091 100644
--- a/app/components/budgets/phases_component.html.erb
+++ b/app/components/budgets/phases_component.html.erb
@@ -1,7 +1,7 @@
 <ul class="no-bullet budget-phases">
   <% budget.published_phases.each do |phase| %>
     <li class="phase <%= "is-active" if phase.current? %>">
-      <h3><%= t("budgets.phase.#{phase.kind}") %></h3>
+      <h3><%= phase.name %></h3>
       <span>
         <%= l(phase.starts_at.to_date, format: :long) if phase.starts_at.present? %>
         -
diff --git a/app/models/budget.rb b/app/models/budget.rb
index b36535278..c030d2dd8 100644
--- a/app/models/budget.rb
+++ b/app/models/budget.rb
@@ -155,10 +155,6 @@ class Budget < ApplicationRecord
     heading_ids.include?(heading.id) ? heading.price : -1
   end
 
-  def translated_phase
-    I18n.t "budgets.phase.#{phase}"
-  end
-
   def formatted_amount(amount)
     ActionController::Base.helpers.number_to_currency(amount,
                                                       precision: 0,
diff --git a/app/models/budget/phase.rb b/app/models/budget/phase.rb
index 022937ce1..aed6abc01 100644
--- a/app/models/budget/phase.rb
+++ b/app/models/budget/phase.rb
@@ -36,6 +36,10 @@ class Budget
       PHASE_KINDS[PHASE_KINDS.index(phase)..-1]
     end
 
+    def name
+      Class.new.extend(ActionView::Helpers::TranslationHelper).t("budgets.phase.#{kind}")
+    end
+
     def next_enabled_phase
       next_phase&.enabled? ? next_phase : next_phase&.next_enabled_phase
     end
@@ -81,7 +85,7 @@ class Budget
         if enabled? && starts_at.present? && prev_enabled_phase.present?
           prev_enabled_phase.assign_attributes(ends_at: starts_at)
           if prev_enabled_phase.invalid_dates_range?
-            phase_name = I18n.t("budgets.phase.#{prev_enabled_phase.kind}")
+            phase_name = prev_enabled_phase.name
             error = I18n.t("budgets.phases.errors.prev_phase_dates_invalid", phase_name: phase_name)
             errors.add(:starts_at, error)
           end
@@ -92,7 +96,7 @@ class Budget
         if enabled? && ends_at.present? && next_enabled_phase.present?
           next_enabled_phase.assign_attributes(starts_at: ends_at)
           if next_enabled_phase.invalid_dates_range?
-            phase_name = I18n.t("budgets.phase.#{next_enabled_phase.kind}")
+            phase_name = next_enabled_phase.name
             error = I18n.t("budgets.phases.errors.next_phase_dates_invalid", phase_name: phase_name)
             errors.add(:ends_at, error)
           end
diff --git a/app/views/admin/budget_phases/edit.html.erb b/app/views/admin/budget_phases/edit.html.erb
index 9cf9a6745..da7b08e21 100644
--- a/app/views/admin/budget_phases/edit.html.erb
+++ b/app/views/admin/budget_phases/edit.html.erb
@@ -2,7 +2,7 @@
 
 <div class="row">
   <div class="small-12 column">
-    <h2><%= t("admin.budgets.edit.title") %> - <%= t("budgets.phase.#{@phase.kind}") %></h2>
+    <h2><%= t("admin.budgets.edit.title") %> - <%= @phase.name %></h2>
   </div>
 </div>
 
diff --git a/app/views/admin/budgets/_form.html.erb b/app/views/admin/budgets/_form.html.erb
index 990dfecc5..c2c243763 100644
--- a/app/views/admin/budgets/_form.html.erb
+++ b/app/views/admin/budgets/_form.html.erb
@@ -59,7 +59,7 @@
         <% @budget.phases.order(:id).each do |phase| %>
           <tr id="<%= dom_id(phase) %>" class="phase">
             <td>
-              <%= t("budgets.phase.#{phase.kind}") %>
+              <%= phase.name %>
               <% if phase.current? %>
                 <span class="label success"><strong><%= t("admin.budgets.edit.active") %></strong></span>
               <% end %>
diff --git a/app/views/admin/budgets/index.html.erb b/app/views/admin/budgets/index.html.erb
index 64e6cb946..79da7b03a 100644
--- a/app/views/admin/budgets/index.html.erb
+++ b/app/views/admin/budgets/index.html.erb
@@ -29,7 +29,7 @@
             <strong><%= budget.name %></strong>
           </td>
           <td class="small">
-            <%= t("budgets.phase.#{budget.phase}") %>
+            <%= budget.current_phase.name %>
           </td>
           <td>
             <%= render Admin::Budgets::TableActionsComponent.new(budget) %>
diff --git a/app/views/budgets/index.html.erb b/app/views/budgets/index.html.erb
index c5309b528..a1a8729ae 100644
--- a/app/views/budgets/index.html.erb
+++ b/app/views/budgets/index.html.erb
@@ -23,7 +23,7 @@
           <p>
             <strong><%= t("budgets.show.phase") %></strong>
           </p>
-          <h2><%= t("budgets.phase.#{current_budget.phase}") %></h2>
+          <h2><%= current_budget.current_phase.name %></h2>
 
           <%= link_to t("budgets.index.section_header.all_phases"), "#all_phases" %>
 
diff --git a/app/views/budgets/show.html.erb b/app/views/budgets/show.html.erb
index a35affe18..4fef4f6f0 100644
--- a/app/views/budgets/show.html.erb
+++ b/app/views/budgets/show.html.erb
@@ -15,7 +15,7 @@
       <p>
         <strong><%= t("budgets.show.phase") %></strong>
       </p>
-      <h2><%= t("budgets.phase.#{@budget.phase}") %></h2>
+      <h2><%= @budget.current_phase.name %></h2>
 
       <% if @budget.accepting? %>
         <% if current_user %>
diff --git a/app/views/management/budgets/create_investments.html.erb b/app/views/management/budgets/create_investments.html.erb
index 9c9f00909..2390f8c51 100644
--- a/app/views/management/budgets/create_investments.html.erb
+++ b/app/views/management/budgets/create_investments.html.erb
@@ -13,7 +13,7 @@
       <% @budgets.each do |budget| %>
         <tr id="<%= dom_id(budget) %>">
           <td><%= budget.name %></td>
-          <td><%= budget.translated_phase %></td>
+          <td><%= budget.current_phase.name %></td>
           <td align="right">
             <%= link_to t("management.budgets.create_new_investment"),
                         new_management_budget_investment_path(budget),
diff --git a/app/views/management/budgets/print_investments.html.erb b/app/views/management/budgets/print_investments.html.erb
index ebc7ed768..9bb4d7ea3 100644
--- a/app/views/management/budgets/print_investments.html.erb
+++ b/app/views/management/budgets/print_investments.html.erb
@@ -11,7 +11,7 @@
   <tbody>
     <tr id="<%= dom_id(@budget) %>">
       <td><%= @budget.name %></td>
-      <td><%= @budget.translated_phase %></td>
+      <td><%= @budget.current_phase.name %></td>
       <td align="right">
         <%= link_to t("management.budgets.print_investments"),
           print_management_budget_investments_path(@budget) %>
diff --git a/app/views/management/budgets/support_investments.html.erb b/app/views/management/budgets/support_investments.html.erb
index 49ddc9461..4da6e5fe9 100644
--- a/app/views/management/budgets/support_investments.html.erb
+++ b/app/views/management/budgets/support_investments.html.erb
@@ -13,7 +13,7 @@
       <% @budgets.each do |budget| %>
         <tr id="<%= dom_id(budget) %>">
           <td><%= budget.name %></td>
-          <td><%= budget.translated_phase %></td>
+          <td><%= budget.current_phase.name %></td>
           <td align="right">
             <%= link_to t("management.budgets.support_investments"),
                         management_budget_investments_path(budget),
diff --git a/app/views/valuation/budgets/index.html.erb b/app/views/valuation/budgets/index.html.erb
index 1e98cf23e..fae10257b 100644
--- a/app/views/valuation/budgets/index.html.erb
+++ b/app/views/valuation/budgets/index.html.erb
@@ -16,7 +16,7 @@
           <%= @budget.name %>
         </td>
         <td>
-          <%= t("budgets.phase.#{@budget.phase}") %>
+          <%= @budget.current_phase.name %>
         </td>
         <td>
           <%= @investments.count %>