From 00eb1149b93104644b5b2a23c6988eba5befd644 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 9 Jul 2025 16:51:16 +0200 Subject: [PATCH] Move custom pages form partial to a component This way changing it will be easier. Note we're changing the name of the HTML class to follow our naming conventions; the `edit_page` class wasn't used anywhere, so we don't need to change anything else. --- .../site_customization/pages/edit_component.html.erb | 2 +- .../site_customization/pages/form_component.html.erb} | 6 +++--- .../admin/site_customization/pages/form_component.rb | 9 +++++++++ .../site_customization/pages/new_component.html.erb | 2 +- 4 files changed, 14 insertions(+), 5 deletions(-) rename app/{views/admin/site_customization/pages/_form.html.erb => components/admin/site_customization/pages/form_component.html.erb} (87%) create mode 100644 app/components/admin/site_customization/pages/form_component.rb diff --git a/app/components/admin/site_customization/pages/edit_component.html.erb b/app/components/admin/site_customization/pages/edit_component.html.erb index f408bd9ef..81564f946 100644 --- a/app/components/admin/site_customization/pages/edit_component.html.erb +++ b/app/components/admin/site_customization/pages/edit_component.html.erb @@ -11,4 +11,4 @@ ) %> <% end %> -<%= render "form" %> +<%= render Admin::SiteCustomization::Pages::FormComponent.new(page) %> diff --git a/app/views/admin/site_customization/pages/_form.html.erb b/app/components/admin/site_customization/pages/form_component.html.erb similarity index 87% rename from app/views/admin/site_customization/pages/_form.html.erb rename to app/components/admin/site_customization/pages/form_component.html.erb index 36e65c54e..9fcabb9de 100644 --- a/app/views/admin/site_customization/pages/_form.html.erb +++ b/app/components/admin/site_customization/pages/form_component.html.erb @@ -1,7 +1,7 @@ -<%= render "shared/globalize_locales", resource: @page %> +<%= render "shared/globalize_locales", resource: page %> -<%= translatable_form_for [:admin, @page], html: { class: "edit_page" } do |f| %> - <%= render "shared/errors", resource: @page %> +<%= translatable_form_for [:admin, page], html: { class: "site-customization-pages-form" } do |f| %> + <%= render "shared/errors", resource: page %>
diff --git a/app/components/admin/site_customization/pages/form_component.rb b/app/components/admin/site_customization/pages/form_component.rb new file mode 100644 index 000000000..d503d0c79 --- /dev/null +++ b/app/components/admin/site_customization/pages/form_component.rb @@ -0,0 +1,9 @@ +class Admin::SiteCustomization::Pages::FormComponent < ApplicationComponent + include TranslatableFormHelper + include GlobalizeHelper + attr_reader :page + + def initialize(page) + @page = page + end +end diff --git a/app/components/admin/site_customization/pages/new_component.html.erb b/app/components/admin/site_customization/pages/new_component.html.erb index aee470c74..593b67142 100644 --- a/app/components/admin/site_customization/pages/new_component.html.erb +++ b/app/components/admin/site_customization/pages/new_component.html.erb @@ -3,4 +3,4 @@ <%= header %> -<%= render "form" %> +<%= render Admin::SiteCustomization::Pages::FormComponent.new(page) %>