1b8a079727
As mentioned in commits likea586ba806,a7664ad81,006128da5,b41fbfa52andc480cdd91, accessing the database after starting the browser with the `visit` method sometimes results in database corruption and failing tests on our CI due to the process running the test accessing the database after the process running the browser has started. For example, one of these tests has recently failed on our CI: ``` 3) Users Create a level 3 user with email from scratch Failure/Error: expect(user.reload).to be_confirmed expected `#<User id: 2060, email: "pepe@gmail.com", created_at: "2025-03-12 19:51:03.688867000 +0100", updated_...d_debates: true, recommended_proposals: true, subscriptions_token: nil, registering_from_web: false>.confirmed?` to be truthy, got false ``` IMHO this is also a bad practice for system tests, since these tests should be checking what users experience. So we're modifying the tests to check the results of users interaction from the point of view of the users. For example, instead of checking that a user is now level 3 verified in the database, we're checking that the user interface states that the user is level 3 verified. Note we're adding an offset when editing the map marker by clicking on `map-location` with `.click(x: 30, y: 30)`. This way we make sure that both the latitude and longitude change from the original values; we used to clicking in the middle (no offset), which didn't change the longitude and changed the latitude just by coincidence. Also note we aren't changing tests with the `:no_js` tag, since these tests don't run a real browser in a separate process. In the future, we should also change most of these tests so they don't access the database and they use a real browser.
81 lines
2.1 KiB
Ruby
81 lines
2.1 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "SMS Verification" do
|
|
scenario "Verify" do
|
|
allow_any_instance_of(Verification::Sms).to receive(:generate_confirmation_code).and_return("5678")
|
|
user = create(:user, residence_verified_at: Time.current)
|
|
login_as(user)
|
|
|
|
visit new_sms_path
|
|
confirm_phone(code: "5678")
|
|
|
|
expect(page).to have_content "Code correct"
|
|
end
|
|
|
|
scenario "Errors on phone number" do
|
|
user = create(:user, residence_verified_at: Time.current)
|
|
login_as(user)
|
|
|
|
visit new_sms_path
|
|
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content error_message("phone")
|
|
end
|
|
|
|
scenario "Errors on verification code" do
|
|
user = create(:user, residence_verified_at: Time.current)
|
|
login_as(user)
|
|
|
|
visit new_sms_path
|
|
|
|
fill_in "sms_phone", with: "611111111"
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content "Security code confirmation"
|
|
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content "Incorrect confirmation code"
|
|
end
|
|
|
|
scenario "Deny access unless residency verified" do
|
|
user = create(:user)
|
|
login_as(user)
|
|
|
|
visit new_sms_path
|
|
|
|
expect(page).to have_content "You have not yet confirmed your residency"
|
|
expect(page).to have_current_path(new_residence_path)
|
|
end
|
|
|
|
scenario "5 tries allowed" do
|
|
user = create(:user, residence_verified_at: Time.current)
|
|
login_as(user)
|
|
|
|
visit new_sms_path
|
|
|
|
5.times do
|
|
fill_in "sms_phone", with: "611111111"
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content "Enter the confirmation code sent to you by text message"
|
|
|
|
click_link "Click here to send it again"
|
|
|
|
expect(page).not_to have_content "Enter the confirmation code sent to you by text message"
|
|
end
|
|
|
|
expect(page).to have_content "You have reached the maximum number of attempts. Please try again later."
|
|
expect(page).to have_current_path(account_path)
|
|
|
|
visit root_path
|
|
|
|
expect(page).not_to have_content "You have reached the maximum number of attempts"
|
|
|
|
visit new_sms_path
|
|
expect(page).to have_content "You have reached the maximum number of attempts. Please try again later."
|
|
expect(page).to have_current_path(account_path)
|
|
end
|
|
end
|