f47179ff68
People using screen readers usually expect links to take them somewhere else in the page on to a different page, while they expect buttons to change something on the page. Since we're in the latter scenario, using a button is more accessible. It's also more natural; with a button, we don't need to provide `#` as the URL or stop the default event when the button is clicked. And, unlike links, buttons can be activated with either the space or the enter key. Finally, clicking a link pointing to `#` with the middle mouse button opens a useless new tab, while buttons do nothing in this case. Now that we only have one "All" link on the page, we no longer need to specify which "All" link we're clicking or which "All" link we are checking, so we're simplifying the code doing so.
214 lines
8.1 KiB
Ruby
214 lines
8.1 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Moderate proposal notifications" do
|
|
scenario "Hide" do
|
|
citizen = create(:user)
|
|
proposal = create(:proposal)
|
|
proposal_notification = create(:proposal_notification,
|
|
proposal: proposal,
|
|
created_at: Date.current - 4.days)
|
|
moderator = create(:moderator)
|
|
|
|
login_as(moderator.user)
|
|
visit proposal_path(proposal)
|
|
click_link "Notifications (1)"
|
|
|
|
within("#proposal_notification_#{proposal_notification.id}") do
|
|
accept_confirm("Are you sure? Hide") { click_button "Hide" }
|
|
end
|
|
|
|
expect(page).to have_css("#proposal_notification_#{proposal_notification.id}.faded")
|
|
|
|
logout
|
|
login_as(citizen)
|
|
visit proposal_path(proposal)
|
|
|
|
expect(page).to have_content "Notifications (0)"
|
|
end
|
|
|
|
scenario "Can not hide own proposal notification" do
|
|
moderator = create(:moderator)
|
|
proposal = create(:proposal, author: moderator.user)
|
|
proposal_notification = create(:proposal_notification,
|
|
proposal: proposal,
|
|
created_at: Date.current - 4.days)
|
|
|
|
login_as(moderator.user)
|
|
visit proposal_path(proposal)
|
|
click_link "Notifications (1)"
|
|
|
|
within("#proposal_notification_#{proposal_notification.id}") do
|
|
expect(page).not_to have_button "Hide"
|
|
expect(page).not_to have_button "Block author"
|
|
end
|
|
end
|
|
|
|
describe "/moderation/ screen" do
|
|
before do
|
|
moderator = create(:moderator)
|
|
login_as(moderator.user)
|
|
end
|
|
|
|
describe "moderate in bulk" do
|
|
describe "When a proposal has been selected for moderation" do
|
|
let!(:proposal_notification) { create(:proposal_notification, created_at: Date.current - 4.days) }
|
|
|
|
before do
|
|
visit moderation_proposal_notifications_path
|
|
click_link "All"
|
|
|
|
within("#proposal_notification_#{proposal_notification.id}") do
|
|
check "proposal_notification_#{proposal_notification.id}_check"
|
|
end
|
|
end
|
|
|
|
scenario "Hide the proposal" do
|
|
accept_confirm("Are you sure? Hide proposals") { click_button "Hide proposals" }
|
|
|
|
expect(page).not_to have_css("#proposal_notification_#{proposal_notification.id}")
|
|
|
|
click_link "Block users"
|
|
fill_in "email or name of user", with: proposal_notification.author.email
|
|
click_button "Search"
|
|
|
|
within "tr", text: proposal_notification.author.name do
|
|
expect(page).to have_button "Block"
|
|
end
|
|
end
|
|
|
|
scenario "Block the author" do
|
|
author = create(:user)
|
|
proposal_notification.update!(author: author)
|
|
|
|
accept_confirm("Are you sure? Block authors") { click_button "Block authors" }
|
|
|
|
expect(page).not_to have_css("#proposal_notification_#{proposal_notification.id}")
|
|
|
|
click_link "Block users"
|
|
fill_in "email or name of user", with: proposal_notification.author.email
|
|
click_button "Search"
|
|
|
|
within "tr", text: proposal_notification.author.name do
|
|
expect(page).to have_content "Blocked"
|
|
end
|
|
end
|
|
|
|
scenario "Ignore the proposal", :no_js do
|
|
click_button "Mark as viewed"
|
|
|
|
expect(proposal_notification.reload).to be_ignored
|
|
expect(proposal_notification.reload).not_to be_hidden
|
|
expect(proposal_notification.author).not_to be_hidden
|
|
end
|
|
end
|
|
|
|
scenario "select all/none" do
|
|
create_list(:proposal_notification, 2)
|
|
|
|
visit moderation_proposal_notifications_path
|
|
click_link "All"
|
|
|
|
expect(page).to have_field type: :checkbox, count: 2
|
|
|
|
within(".check-all-none") { click_button "All" }
|
|
|
|
expect(all(:checkbox)).to all(be_checked)
|
|
|
|
within(".check-all-none") { click_button "None" }
|
|
|
|
all(:checkbox).each { |checkbox| expect(checkbox).not_to be_checked }
|
|
end
|
|
|
|
scenario "remembering page, filter and order" do
|
|
stub_const("#{ModerateActions}::PER_PAGE", 2)
|
|
create_list(:proposal_notification, 4)
|
|
|
|
visit moderation_proposal_notifications_path(filter: "all", page: "2", order: "created_at")
|
|
|
|
accept_confirm("Are you sure? Mark as viewed") { click_button "Mark as viewed" }
|
|
|
|
expect(page).to have_link "Most recent", class: "is-active"
|
|
expect(page).to have_link "Moderated"
|
|
|
|
expect(page).to have_current_path(/filter=all/)
|
|
expect(page).to have_current_path(/page=2/)
|
|
expect(page).to have_current_path(/order=created_at/)
|
|
end
|
|
end
|
|
|
|
scenario "Current filter is properly highlighted" do
|
|
visit moderation_proposal_notifications_path
|
|
expect(page).not_to have_link("Pending review")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Mark as viewed")
|
|
|
|
visit moderation_proposal_notifications_path(filter: "all")
|
|
expect(page).not_to have_link("All")
|
|
expect(page).to have_link("Pending review")
|
|
expect(page).to have_link("Mark as viewed")
|
|
|
|
visit moderation_proposal_notifications_path(filter: "pending_review")
|
|
expect(page).to have_link("All")
|
|
expect(page).not_to have_link("Pending review")
|
|
expect(page).to have_link("Mark as viewed")
|
|
|
|
visit moderation_proposal_notifications_path(filter: "ignored")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Pending review")
|
|
expect(page).not_to have_link("Marked as viewed")
|
|
end
|
|
|
|
scenario "Filtering proposals" do
|
|
proposal = create(:proposal)
|
|
create(:proposal_notification, title: "Regular proposal", proposal: proposal)
|
|
create(:proposal_notification, :moderated, title: "Pending proposal", proposal: proposal)
|
|
create(:proposal_notification, :hidden, title: "Hidden proposal", proposal: proposal)
|
|
create(:proposal_notification, :moderated, :ignored, title: "Ignored proposal", proposal: proposal)
|
|
|
|
visit moderation_proposal_notifications_path(filter: "all")
|
|
expect(page).to have_content("Regular proposal")
|
|
expect(page).to have_content("Pending proposal")
|
|
expect(page).not_to have_content("Hidden proposal")
|
|
expect(page).to have_content("Ignored proposal")
|
|
|
|
visit moderation_proposal_notifications_path(filter: "pending_review")
|
|
expect(page).not_to have_content("Regular proposal")
|
|
expect(page).to have_content("Pending proposal")
|
|
expect(page).not_to have_content("Hidden proposal")
|
|
expect(page).not_to have_content("Ignored proposal")
|
|
|
|
visit moderation_proposal_notifications_path(filter: "ignored")
|
|
expect(page).not_to have_content("Regular proposal")
|
|
expect(page).not_to have_content("Pending proposal")
|
|
expect(page).not_to have_content("Hidden proposal")
|
|
expect(page).to have_content("Ignored proposal")
|
|
end
|
|
|
|
scenario "sorting proposal notifications" do
|
|
moderated_notification = create(:proposal_notification,
|
|
:moderated,
|
|
title: "Moderated notification",
|
|
created_at: 1.day.ago)
|
|
moderated_new_notification = create(:proposal_notification,
|
|
:moderated,
|
|
title: "Moderated new notification",
|
|
created_at: 12.hours.ago)
|
|
newer_notification = create(:proposal_notification,
|
|
title: "Newer notification",
|
|
created_at: Time.current)
|
|
old_moderated_notification = create(:proposal_notification,
|
|
:moderated,
|
|
title: "Older notification",
|
|
created_at: 2.days.ago)
|
|
|
|
visit moderation_proposal_notifications_path(filter: "all", order: "created_at")
|
|
|
|
expect(moderated_new_notification.title).to appear_before(moderated_notification.title)
|
|
|
|
visit moderation_proposal_notifications_path(filter: "all", order: "moderated")
|
|
|
|
expect(old_moderated_notification.title).to appear_before(newer_notification.title)
|
|
end
|
|
end
|
|
end
|