930bb753c5
Our previous system to delete cached attachments didn't work for documents because the `custom_hash_data` is different for files created from a file and files created from cached attachments. When creating a document attachment, the name of the file is taken into account to calculate the hash. Let's say the original file name is "logo.pdf", and the generated hash is "123456". The cached attachment will be "123456.pdf", so the generated hash using the cached attachment will be something different, like "28af3". So the file that will be removed will be "28af3.pdf", and not "123456.pdf", which will still be present. Furthermore, there are times where users choose a file and then they close the browser or go to a different page. In those cases, we weren't deleting the cached attachments either. So we're adding a rake task to delete these files once a day. This way we can simplify the logic we were using to destroy cached attachments. Note there's related a bug in documents: when editing a record (for example, a proposal), if the title of the document changes, its hash changes, and so it will be impossible to generate a link to that document. Changing the way this hash is generated is not an option because it would break links to existing files. We'll try to fix it when moving to Active Storage.
62 lines
1.9 KiB
Ruby
62 lines
1.9 KiB
Ruby
class DirectUpload
|
|
include ActiveModel::Validations
|
|
include ActiveModel::Conversion
|
|
extend ActiveModel::Naming
|
|
|
|
attr_accessor :resource, :resource_type, :resource_id,
|
|
:relation, :resource_relation,
|
|
:attachment, :cached_attachment, :user
|
|
|
|
validates :attachment, :resource_type, :resource_relation, :user, presence: true
|
|
validate :parent_resource_attachment_validations,
|
|
if: -> { attachment.present? && resource_type.present? && resource_relation.present? && user.present? }
|
|
|
|
def initialize(attributes = {})
|
|
attributes.each do |name, value|
|
|
send("#{name}=", value)
|
|
end
|
|
|
|
if @resource_type.present? && @resource_relation.present? && (@attachment.present? || @cached_attachment.present?)
|
|
@resource = @resource_type.constantize.find_or_initialize_by(id: @resource_id)
|
|
|
|
# Refactor
|
|
@relation = if @resource.respond_to?(:images) &&
|
|
((@attachment.present? && !@attachment.content_type.match(/pdf/)) || @cached_attachment.present?)
|
|
@resource.images.send("build", relation_attributtes)
|
|
elsif @resource.class.reflections[@resource_relation].macro == :has_one
|
|
@resource.send("build_#{resource_relation}", relation_attributtes)
|
|
else
|
|
@resource.send(@resource_relation).build(relation_attributtes)
|
|
end
|
|
|
|
@relation.user = user
|
|
end
|
|
end
|
|
|
|
def save_attachment
|
|
@relation.attachment.save
|
|
end
|
|
|
|
def persisted?
|
|
false
|
|
end
|
|
|
|
private
|
|
|
|
def parent_resource_attachment_validations
|
|
@relation.valid?
|
|
|
|
if @relation.errors.key? :attachment
|
|
errors.add(:attachment, @relation.errors.full_messages_for(:attachment))
|
|
end
|
|
end
|
|
|
|
def relation_attributtes
|
|
{
|
|
attachment: @attachment,
|
|
cached_attachment: @cached_attachment,
|
|
user: @user
|
|
}
|
|
end
|
|
end
|