de436e33a4
In regular system tests, we prefer testing against the text of the link because it's easier to recognize which link we're talking about. I was wondering whether we should remove the `title` attribute completely and use just the `aria-label` attribute. Quoting The Paciello Group blog [1]: "If you want to hide content from mobile and tablet users as well as assistive tech users and keyboard only users, use the title attribute." However, there's a case where mouse users might find the title attribute useful. When visiting an investment page, the connection between the "Support" link and the investment is not as clear as it is in the investments index page, so it might not be clear what you're supporting. As mentioned, though, this information will only be relevant for mouse users, who nowadays represent less than half of our users. [1] https://www.tpgi.com/using-the-html-title-attribute-updated/
228 lines
8.4 KiB
Ruby
228 lines
8.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Votes" do
|
|
let(:manuela) { create(:user, verified_at: Time.current) }
|
|
|
|
context "Investments - Knapsack" do
|
|
let(:budget) { create(:budget, phase: "selecting") }
|
|
let(:group) { create(:budget_group, budget: budget) }
|
|
let(:heading) { create(:budget_heading, group: group) }
|
|
|
|
before { login_as(manuela) }
|
|
|
|
describe "Index" do
|
|
scenario "Index shows user votes on proposals" do
|
|
investment1 = create(:budget_investment, heading: heading, voters: [manuela])
|
|
investment2 = create(:budget_investment, heading: heading)
|
|
investment3 = create(:budget_investment, heading: heading)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
within("#budget-investments") do
|
|
within("#budget_investment_#{investment1.id}_votes") do
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
within("#budget_investment_#{investment2.id}_votes") do
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
within("#budget_investment_#{investment3.id}_votes") do
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Create from investments' index" do
|
|
create(:budget_investment, heading: heading)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
within(".supports") do
|
|
click_link "Support"
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "Single investment" do
|
|
let(:investment) { create(:budget_investment, heading: heading) }
|
|
|
|
scenario "Show no votes" do
|
|
visit budget_investment_path(budget, investment)
|
|
expect(page).to have_content "No supports"
|
|
end
|
|
|
|
scenario "Trying to vote multiple times" do
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
within(".supports") do
|
|
find(".in-favor a").click
|
|
expect(page).to have_content "1 support"
|
|
|
|
expect(page).not_to have_selector ".in-favor a"
|
|
end
|
|
end
|
|
|
|
scenario "Create from investment show" do
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
within(".supports") do
|
|
find(".in-favor a").click
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Disable voting on investments" do
|
|
budget.update!(phase: "reviewing")
|
|
investment = create(:budget_investment, heading: heading)
|
|
|
|
manuela = create(:user, verified_at: Time.current)
|
|
login_as(manuela)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
within("#budget_investment_#{investment.id}") do
|
|
expect(page).not_to have_css("budget_investment_#{investment.id}_votes")
|
|
end
|
|
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
within("#budget_investment_#{investment.id}") do
|
|
expect(page).not_to have_css("budget_investment_#{investment.id}_votes")
|
|
end
|
|
end
|
|
|
|
context "Voting in multiple headings of a single group" do
|
|
let(:new_york) { heading }
|
|
let(:san_francisco) { create(:budget_heading, group: group) }
|
|
let(:third_heading) { create(:budget_heading, group: group) }
|
|
|
|
let!(:new_york_investment) { create(:budget_investment, heading: new_york) }
|
|
let!(:san_francisco_investment) { create(:budget_investment, heading: san_francisco) }
|
|
let!(:third_heading_investment) { create(:budget_investment, heading: third_heading) }
|
|
|
|
before do
|
|
group.update(max_votable_headings: 2)
|
|
end
|
|
|
|
scenario "From Index" do
|
|
visit budget_investments_path(budget, heading_id: new_york.id)
|
|
|
|
within("#budget_investment_#{new_york_investment.id}") do
|
|
accept_confirm { find(".in-favor a").click }
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
visit budget_investments_path(budget, heading_id: san_francisco.id)
|
|
|
|
within("#budget_investment_#{san_francisco_investment.id}") do
|
|
find(".in-favor a").click
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
visit budget_investments_path(budget, heading_id: third_heading.id)
|
|
|
|
within("#budget_investment_#{third_heading_investment.id}") do
|
|
find(".in-favor a").click
|
|
|
|
expect(page).to have_content "You can only support investment projects in 2 districts. "\
|
|
"You have already supported investments in"
|
|
|
|
participation = find(".participation-not-allowed")
|
|
headings = participation.text
|
|
.match(/You have already supported investments in (.+) and (.+)\./)&.captures
|
|
|
|
expect(headings).to match_array [new_york.name, san_francisco.name]
|
|
|
|
expect(page).not_to have_content "1 support"
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
|
|
scenario "From show" do
|
|
visit budget_investment_path(budget, new_york_investment)
|
|
|
|
accept_confirm { find(".in-favor a").click }
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. Share it!"
|
|
|
|
visit budget_investment_path(budget, san_francisco_investment)
|
|
|
|
find(".in-favor a").click
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. Share it!"
|
|
|
|
visit budget_investment_path(budget, third_heading_investment)
|
|
|
|
find(".in-favor a").click
|
|
expect(page).to have_content "You can only support investment projects in 2 districts. "\
|
|
"You have already supported investments in"
|
|
|
|
participation = find(".participation-not-allowed")
|
|
headings = participation.text
|
|
.match(/You have already supported investments in (.+) and (.+)\./)&.captures
|
|
|
|
expect(headings).to match_array [new_york.name, san_francisco.name]
|
|
|
|
expect(page).not_to have_content "1 support"
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
scenario "Confirm message shows the right text" do
|
|
visit budget_investments_path(budget, heading_id: new_york.id)
|
|
find(".in-favor a").click
|
|
|
|
expect(page.driver.send(:find_modal).text).to match "You can only support investments in 2 districts."
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Investments - Approval" do
|
|
let(:budget) { create(:budget, :balloting, :approval) }
|
|
before { login_as(manuela) }
|
|
|
|
scenario "Budget limit is ignored" do
|
|
group = create(:budget_group, budget: budget)
|
|
heading = create(:budget_heading, group: group, max_ballot_lines: 2)
|
|
investment1 = create(:budget_investment, :selected, heading: heading, price: heading.price)
|
|
investment2 = create(:budget_investment, :selected, heading: heading, price: heading.price)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
add_to_ballot(investment1.title)
|
|
|
|
expect(page).to have_content("Remove vote")
|
|
expect(page).to have_content("YOU CAN STILL CAST 1 VOTE")
|
|
|
|
within(".budget-investment", text: investment2.title) do
|
|
find("div.ballot").hover
|
|
|
|
expect(page).not_to have_content("You have already assigned the available budget")
|
|
end
|
|
|
|
visit budget_ballot_path(budget)
|
|
|
|
expect(page).to have_content("you can change your vote at any time until this phase is closed")
|
|
end
|
|
end
|
|
end
|