1b8a079727
As mentioned in commits likea586ba806,a7664ad81,006128da5,b41fbfa52andc480cdd91, accessing the database after starting the browser with the `visit` method sometimes results in database corruption and failing tests on our CI due to the process running the test accessing the database after the process running the browser has started. For example, one of these tests has recently failed on our CI: ``` 3) Users Create a level 3 user with email from scratch Failure/Error: expect(user.reload).to be_confirmed expected `#<User id: 2060, email: "pepe@gmail.com", created_at: "2025-03-12 19:51:03.688867000 +0100", updated_...d_debates: true, recommended_proposals: true, subscriptions_token: nil, registering_from_web: false>.confirmed?` to be truthy, got false ``` IMHO this is also a bad practice for system tests, since these tests should be checking what users experience. So we're modifying the tests to check the results of users interaction from the point of view of the users. For example, instead of checking that a user is now level 3 verified in the database, we're checking that the user interface states that the user is level 3 verified. Note we're adding an offset when editing the map marker by clicking on `map-location` with `.click(x: 30, y: 30)`. This way we make sure that both the latitude and longitude change from the original values; we used to clicking in the middle (no offset), which didn't change the longitude and changed the latitude just by coincidence. Also note we aren't changing tests with the `:no_js` tag, since these tests don't run a real browser in a separate process. In the future, we should also change most of these tests so they don't access the database and they use a real browser.
160 lines
4.7 KiB
Ruby
160 lines
4.7 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Residence" do
|
|
before { create(:geozone) }
|
|
|
|
scenario "Verify resident" do
|
|
user = create(:user)
|
|
login_as(user)
|
|
|
|
visit account_path
|
|
click_link "Verify my account"
|
|
|
|
fill_in "Document number", with: "12345678Z"
|
|
select "DNI", from: "residence_document_type"
|
|
fill_in "Date of birth", with: Date.new(1980, 12, 31)
|
|
fill_in "residence_postal_code", with: "28013"
|
|
check "residence_terms_of_service"
|
|
click_button "Verify residence"
|
|
|
|
expect(page).to have_content "Residence verified"
|
|
end
|
|
|
|
scenario "Verify resident throught RemoteCensusApi", :remote_census do
|
|
user = create(:user)
|
|
login_as(user)
|
|
mock_valid_remote_census_response
|
|
|
|
visit account_path
|
|
click_link "Verify my account"
|
|
|
|
fill_in "Document number", with: "12345678Z"
|
|
select "DNI", from: "residence_document_type"
|
|
fill_in "Date of birth", with: Date.new(1980, 12, 31)
|
|
fill_in "residence_postal_code", with: "28013"
|
|
check "residence_terms_of_service"
|
|
click_button "Verify residence"
|
|
|
|
expect(page).to have_content "Residence verified"
|
|
end
|
|
|
|
scenario "When trying to verify a deregistered account old votes are reassigned" do
|
|
erased_user = create(:user, document_number: "12345678Z", document_type: "1", erased_at: Time.current)
|
|
new_user = create(:user)
|
|
debate = create(:debate, title: "Improve everything")
|
|
create(:vote, voter: erased_user, votable: debate)
|
|
|
|
login_as(new_user)
|
|
|
|
visit debate_path(debate)
|
|
|
|
expect(page).to have_css "button[aria-pressed='false']", exact_text: "I agree"
|
|
|
|
visit account_path
|
|
click_link "Verify my account"
|
|
|
|
fill_in "Document number", with: "12345678Z"
|
|
select "DNI", from: "residence_document_type"
|
|
fill_in "Date of birth", with: Date.new(1980, 12, 31)
|
|
fill_in "residence_postal_code", with: "28013"
|
|
check "residence_terms_of_service"
|
|
|
|
click_button "Verify residence"
|
|
|
|
expect(page).to have_content "Residence verified"
|
|
|
|
visit debate_path(debate)
|
|
|
|
expect(page).to have_css "button[aria-pressed='true']", exact_text: "I agree"
|
|
end
|
|
|
|
scenario "Error on verify" do
|
|
user = create(:user)
|
|
login_as(user)
|
|
|
|
visit account_path
|
|
click_link "Verify my account"
|
|
|
|
click_button "Verify residence"
|
|
|
|
expect(page).to have_content(/\d errors? prevented the verification of your residence/)
|
|
end
|
|
|
|
scenario "Error on postal code not in census" do
|
|
Setting["postal_codes"] = "00001:99999"
|
|
user = create(:user)
|
|
login_as(user)
|
|
|
|
visit account_path
|
|
click_link "Verify my account"
|
|
|
|
fill_in "Document number", with: "12345678Z"
|
|
select "DNI", from: "residence_document_type"
|
|
fill_in "Date of birth", with: Date.new(1997, 1, 1)
|
|
fill_in "residence_postal_code", with: "00000"
|
|
check "residence_terms_of_service"
|
|
|
|
click_button "Verify residence"
|
|
|
|
expect(page).to have_content "Citizens from this postal code cannot participate"
|
|
end
|
|
|
|
scenario "Error on census" do
|
|
user = create(:user)
|
|
login_as(user)
|
|
|
|
visit account_path
|
|
click_link "Verify my account"
|
|
|
|
fill_in "Document number", with: "12345678Z"
|
|
select "DNI", from: "residence_document_type"
|
|
fill_in "Date of birth", with: Date.new(1997, 1, 1)
|
|
fill_in "residence_postal_code", with: "28013"
|
|
check "residence_terms_of_service"
|
|
|
|
click_button "Verify residence"
|
|
|
|
expect(page).to have_content "The Census was unable to verify your information"
|
|
end
|
|
|
|
scenario "5 tries allowed" do
|
|
user = create(:user)
|
|
login_as(user)
|
|
|
|
visit account_path
|
|
click_link "Verify my account"
|
|
|
|
5.times do
|
|
fill_in "Document number", with: "12345678Z"
|
|
select "DNI", from: "residence_document_type"
|
|
fill_in "Date of birth", with: Date.new(1997, 1, 1)
|
|
fill_in "residence_postal_code", with: "28013"
|
|
check "residence_terms_of_service"
|
|
|
|
click_button "Verify residence"
|
|
expect(page).to have_content "The Census was unable to verify your information"
|
|
|
|
within("#error_explanation") { click_button "Close" }
|
|
expect(page).not_to have_content "The Census was unable to verify your information"
|
|
end
|
|
|
|
click_button "Verify residence"
|
|
expect(page).to have_content "You have reached the maximum number of attempts. Please try again later."
|
|
expect(page).to have_current_path(account_path)
|
|
|
|
visit new_residence_path
|
|
expect(page).to have_content "You have reached the maximum number of attempts. Please try again later."
|
|
expect(page).to have_current_path(account_path)
|
|
end
|
|
|
|
scenario "Terms and conditions link" do
|
|
login_as(create(:user))
|
|
|
|
visit new_residence_path
|
|
|
|
within_window(window_opened_by { click_link "the terms and conditions of access" }) do
|
|
expect(page).to have_content "Terms and conditions of access of the Census"
|
|
end
|
|
end
|
|
end
|