consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
db97f9d08c33a86359479bfc0cd8b2cdf83a7ab6
grecia/app/models
History
Javi Martín db97f9d08c Add and apply rubocop rules for empty lines 
We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
..
abilities
Don't let valuators update investments
2019-10-18 16:24:27 +02:00
ahoy
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
banner
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
budget
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
ckeditor
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
concerns
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
custom
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
dashboard
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
legislation
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
local_census_records
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
milestone
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
officing
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
poll
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
site_customization
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
verification
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
widget
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
.keep
…
ability.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
active_poll.rb
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
activity.rb
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
admin_notification.rb
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
administrator_task.rb
Use Rails 5 conventions in Dashboard
2019-04-29 13:08:43 -05:00
administrator.rb
Add description field to administrator users like evaluators description
2019-06-05 16:18:12 +02:00
application_record.rb
Fix several rubocop warnings
2019-04-17 17:40:56 +02:00
banner.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
budget_administrator.rb
Add historic fields to participatory budget
2019-06-12 18:03:53 +02:00
budget_rol_assignment.rb
Add historic fields to participatory budget
2019-06-12 18:03:53 +02:00
budget_tracker.rb
Add historic fields to participatory budget
2019-06-12 18:03:53 +02:00
budget_valuator.rb
Add historic fields to participatory budget
2019-06-12 18:03:53 +02:00
budget.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
campaign.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
comment_notifier.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
comment.rb
Use respond_to? instead of try
2019-10-22 17:37:51 +02:00
community.rb
Apply IndentationConsistency rubocop rule
2019-09-10 20:02:15 +02:00
dashboard.rb
Fix more hound warnings
2019-03-27 15:22:14 +01:00
debate.rb
Apply Rails/SafeNavigation rubocop rule
2019-09-10 21:43:39 +02:00
direct_message.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
direct_upload.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
document.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
download_setting.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
evaluation_comment_notifier.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
failed_census_call.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
flag.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
follow.rb
Replace all occurrences of ActiveRecord::Base with ApplicationRecord
2019-04-17 17:40:56 +02:00
geozone.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
i18n_content_translation.rb
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
i18n_content.rb
Remove redundant I18nContent scope
2019-09-24 19:29:46 +02:00
identity.rb
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
image.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
legislation.rb
Use double quotes in models
2019-03-14 17:25:43 +01:00
link.rb
Use Rails 5 conventions in Dashboard
2019-04-29 13:08:43 -05:00
local_census_record.rb
Add uniqueness validation to document_number and document_type pair
2019-07-29 13:07:24 +02:00
lock.rb
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
manager.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
map_location.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
milestone.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
moderator.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
newsletter.rb
Apply Rails/FindBy rubocop rule
2019-10-23 18:29:09 +02:00
notification.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
organization.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
poll.rb
Avoid duplicate records in current_or_recounting
2019-09-26 19:58:02 +02:00
progress_bar.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
proposal_notification.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
proposal.rb
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
related_content_score.rb
Replace all occurrences of ActiveRecord::Base with ApplicationRecord
2019-04-17 17:40:56 +02:00
related_content.rb
Apply IndentationConsistency rubocop rule
2019-09-10 20:02:15 +02:00
remote_translation.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
report.rb
Add option to enable advanced stats
2019-05-22 11:50:03 +02:00
setting.rb
Apply Rails/FindBy rubocop rule
2019-10-23 18:29:09 +02:00
signature_sheet.rb
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
signature.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
site_customization.rb
Use double quotes in models
2019-03-14 17:25:43 +01:00
stats_version.rb
Add table to store stats versions
2019-05-21 13:50:19 +02:00
tag_cloud.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
tag.rb
Add models tag spec with 160 chars
2019-02-05 17:41:00 +01:00
topic.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
tracker.rb
Apply Rails/Presence rubocop rule
2019-09-10 21:43:38 +02:00
user.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
valuator_group.rb
Replace all occurrences of ActiveRecord::Base with ApplicationRecord
2019-04-17 17:40:56 +02:00
valuator.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
verified_user.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
visit.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
votation_set_answer.rb
Add Model changes to work with votation_types
2019-06-12 19:32:41 +02:00
votation_type.rb
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
vote.rb
allows querying for a proposal's votes
2017-12-15 19:21:02 +01:00
web_section.rb
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00