We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
19 lines
569 B
Ruby
19 lines
569 B
Ruby
module ValuationHelper
|
|
def valuator_or_group_select_options
|
|
valuator_group_select_options + valuator_select_options
|
|
end
|
|
|
|
def valuator_select_options
|
|
Valuator.order("description ASC").order("users.email ASC").includes(:user).
|
|
collect { |v| [v.description_or_email, "valuator_#{v.id}"] }
|
|
end
|
|
|
|
def valuator_group_select_options
|
|
ValuatorGroup.order("name ASC").collect { |g| [g.name, "group_#{g.id}"] }
|
|
end
|
|
|
|
def explanation_field(field)
|
|
simple_format_no_tags_no_sanitize(sanitize_and_auto_link(field)) if field.present?
|
|
end
|
|
end
|