We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
25 lines
756 B
Ruby
25 lines
756 B
Ruby
module SearchHelper
|
|
def official_level_search_options
|
|
options_for_select((1..5).map { |i| [setting["official_level_#{i}_name"], i] },
|
|
params[:advanced_search].try(:[], :official_level))
|
|
end
|
|
|
|
def date_range_options
|
|
options_for_select([
|
|
[t("shared.advanced_search.date_1"), 1],
|
|
[t("shared.advanced_search.date_2"), 2],
|
|
[t("shared.advanced_search.date_3"), 3],
|
|
[t("shared.advanced_search.date_4"), 4],
|
|
[t("shared.advanced_search.date_5"), "custom"]],
|
|
selected_date_range)
|
|
end
|
|
|
|
def selected_date_range
|
|
custom_date_range? ? "custom" : params[:advanced_search].try(:[], :date_min)
|
|
end
|
|
|
|
def custom_date_range?
|
|
params[:advanced_search].try(:[], :date_max).present?
|
|
end
|
|
end
|