We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
19 lines
608 B
Ruby
19 lines
608 B
Ruby
class Officing::PollsController < Officing::BaseController
|
|
before_action :verify_booth
|
|
|
|
def index
|
|
@polls = current_user.poll_officer? ? current_user.poll_officer.voting_days_assigned_polls : []
|
|
@polls = @polls.select { |poll| poll.current?(Time.current) || poll.current?(1.day.ago) }
|
|
end
|
|
|
|
def final
|
|
@polls = if current_user.poll_officer?
|
|
current_user.poll_officer.final_days_assigned_polls.select do |poll|
|
|
poll.ends_at > 2.weeks.ago && poll.expired? || poll.ends_at.today?
|
|
end
|
|
else
|
|
[]
|
|
end
|
|
end
|
|
end
|