We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
33 lines
827 B
Ruby
33 lines
827 B
Ruby
class Admin::HiddenProposalsController < Admin::BaseController
|
|
include FeatureFlags
|
|
|
|
has_filters %w[without_confirmed_hide all with_confirmed_hide], only: :index
|
|
|
|
feature_flag :proposals
|
|
|
|
before_action :load_proposal, only: [:confirm_hide, :restore]
|
|
|
|
def index
|
|
@proposals = Proposal.only_hidden.send(@current_filter).order(hidden_at: :desc)
|
|
.page(params[:page])
|
|
end
|
|
|
|
def confirm_hide
|
|
@proposal.confirm_hide
|
|
redirect_to request.query_parameters.merge(action: :index)
|
|
end
|
|
|
|
def restore
|
|
@proposal.restore(recursive: true)
|
|
@proposal.ignore_flag
|
|
Activity.log(current_user, :restore, @proposal)
|
|
redirect_to request.query_parameters.merge(action: :index)
|
|
end
|
|
|
|
private
|
|
|
|
def load_proposal
|
|
@proposal = Proposal.with_hidden.find(params[:id])
|
|
end
|
|
end
|