We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
29 lines
660 B
Ruby
29 lines
660 B
Ruby
class Admin::BudgetPhasesController < Admin::BaseController
|
|
include Translatable
|
|
|
|
before_action :load_phase, only: [:edit, :update]
|
|
|
|
def edit
|
|
end
|
|
|
|
def update
|
|
if @phase.update(budget_phase_params)
|
|
notice = t("flash.actions.save_changes.notice")
|
|
redirect_to edit_admin_budget_path(@phase.budget), notice: notice
|
|
else
|
|
render :edit
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def load_phase
|
|
@phase = Budget::Phase.find(params[:id])
|
|
end
|
|
|
|
def budget_phase_params
|
|
valid_attributes = [:starts_at, :ends_at, :enabled]
|
|
params.require(:budget_phase).permit(*valid_attributes, translation_params(Budget::Phase))
|
|
end
|
|
end
|