db25dc13e1
We were using Foundation's accordion menu to open/close nested lists of
links. Unfortunately, Foundation's accordion makes it impossible to
access links in nested links using the keyboard [1] (note the issue is
closed, but in the latest version of Foundation, 6.8.1, it's still
present, and Foundation's development is mostly discontinued).
Furtheremore, it adds the `menuitem` role to links, but ARIA menus are
not ment for navigation but for application behavior and, since it
doesn't add the `menubar` or `menu` roles to the parent elements, it
results in accessibility issues for people using screen readers (also
reported by the Axe accessibility testing engine).
So we need to implement our own solution. We're using the most commonly
used pattern: a buttton with the `aria-expanded` attribute. And, for
people using browsers where JavaScript hasn't loaded, we're keeping the
submenus open at all times (just like we were doing until now), and
we're disabling the buttons (since they do nothing without JavaScript).
This might not be an ideal solution, but it's probably good enough, and
way better than what we had until now.
We've also considered using the <details> and <summary> elements instead
of using buttons to open/close items on the list. However, these
elements still present some accessibility issues [2], and the transition
between open and closed can't be animated unless we overwrite the
`click` event with JavaScript. The pattern of using these elements to
open/close a nested list of links isn't common either, and some people
using screen readers might get confused when entering/leaving the nested
list.
We tried other approaches to get the animation effect, all of them based
on adding `[aria-expanded="false"]:not([disabled]) + * { display: none;
}` to the CSS file.
Unfortunately, animation using CSS isn't feasible right now because
browsers can't animate a change form `height: 0` to `height: auto`.
There are some hacks like animating the `max-height` or the `flex-grow`
property, but the resulting animation is inconsistent. A perfect
animation can be done using the `grid-template-rows` property [3], but
it requires adding a grid container and only works in Firefox and recent
versions of Chrome and similar browsers.
Getting to a solution with JavaScript was also tricky. With the
following approach, `slideToggle()` opened the menu the first time, even
if it was already open (not sure why):
```
toggle_buttons.on("click", function() {
$(this).attr("aria-expanded", !JSON.parse($(this).attr("aria-expanded")));
$(this).next().slideToggle();
});
```
This made the arrow turn after the menu had slided instead of doing it
at the same time:
```
toggle_buttons.on("click", function() {
var button = $(this);
button.next().slideToggle(function() {
button.attr("aria-expanded",
!JSON.parse(button.attr("aria-expanded")));
});
}
```
With this, everything disappeared quickly:
```
toggle_buttons.on("click", function() {
var expanded = JSON.parse($(this).attr("aria-expanded"));
if (expanded) {
$(this).next().slideUp();
} else {
$(this).next().slideDown();
}
$(this).attr("aria-expanded", !expanded);
}
```
So, in the end, we're hiding the nested link lists with JavaScript
instead of CSS.
[1] Issue 12046 in https://github.com/foundation/foundation-sites
[2] https://www.scottohara.me/blog/2022/09/12/details-summary.html
[3] https://css-tricks.com/css-grid-can-do-auto-height-transitions
121 lines
3.4 KiB
Ruby
121 lines
3.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Admin custom images", :admin do
|
|
scenario "Upload valid png image" do
|
|
visit admin_root_path
|
|
|
|
within("#side_menu") do
|
|
click_button "Site content"
|
|
click_link "Custom images"
|
|
end
|
|
|
|
within("tr#image_logo_header") do
|
|
attach_file "site_customization_image_image", file_fixture("logo_header.png")
|
|
click_button "Update"
|
|
end
|
|
|
|
expect(page).to have_css("tr#image_logo_header img[src*='logo_header.png']")
|
|
expect(page).to have_css("img[src*='logo_header.png']", count: 1)
|
|
end
|
|
|
|
scenario "Upload valid jpg image" do
|
|
visit admin_site_customization_images_path
|
|
|
|
within("tr#image_map") do
|
|
attach_file "site_customization_image_image", file_fixture("custom_map.jpg")
|
|
click_button "Update"
|
|
end
|
|
|
|
expect(page).to have_css("tr#image_map img[src*='custom_map.jpg']")
|
|
expect(page).to have_css("img[src*='custom_map.jpg']", count: 1)
|
|
end
|
|
|
|
scenario "Image is replaced on front views" do
|
|
create(:geozone)
|
|
budget = create(:budget)
|
|
group = create(:budget_group, budget: budget)
|
|
|
|
visit admin_site_customization_images_path
|
|
|
|
within("tr#image_map") do
|
|
attach_file "site_customization_image_image", file_fixture("custom_map.jpg")
|
|
click_button "Update"
|
|
end
|
|
|
|
visit proposals_path
|
|
|
|
within("#map") do
|
|
expect(page).to have_css("img[src*='custom_map.jpg']")
|
|
end
|
|
|
|
visit map_proposals_path
|
|
|
|
within(".show-for-medium") do
|
|
expect(page).to have_css("img[src*='custom_map.jpg']")
|
|
end
|
|
|
|
visit budget_group_path(budget, group)
|
|
|
|
within(".show-for-medium") do
|
|
expect(page).to have_css("img[src*='custom_map.jpg']")
|
|
end
|
|
end
|
|
|
|
scenario "Custom apple touch icon is replaced on front views" do
|
|
create(:site_customization_image,
|
|
name: "apple-touch-icon-200",
|
|
image: fixture_file_upload("apple-touch-icon-custom-200.png"))
|
|
|
|
visit root_path
|
|
|
|
expect(page).not_to have_css("link[href*='apple-touch-icon-200']", visible: :all)
|
|
expect(page).to have_css("link[href*='apple-touch-icon-custom-200']", visible: :hidden)
|
|
end
|
|
|
|
scenario "Image is replaced on admin newsletters" do
|
|
newsletter = create(:newsletter, segment_recipient: "all_users")
|
|
|
|
visit admin_site_customization_images_path
|
|
|
|
within("tr#image_logo_email") do
|
|
attach_file "site_customization_image_image", file_fixture("logo_email_custom.png")
|
|
click_button "Update"
|
|
end
|
|
|
|
visit admin_newsletter_path(newsletter)
|
|
|
|
within(".newsletter-body-content") do
|
|
expect(page).to have_css("img[src*='logo_email_custom.png']")
|
|
end
|
|
end
|
|
|
|
scenario "Upload invalid image" do
|
|
visit admin_site_customization_images_path
|
|
|
|
within("tr#image_social_media_icon") do
|
|
attach_file "site_customization_image_image", file_fixture("logo_header.png")
|
|
click_button "Update"
|
|
end
|
|
|
|
expect(page).to have_content("Width must be 470px")
|
|
expect(page).to have_content("Height must be 246px")
|
|
end
|
|
|
|
scenario "Delete image" do
|
|
visit admin_site_customization_images_path
|
|
|
|
within("tr#image_social_media_icon") do
|
|
attach_file "site_customization_image_image", file_fixture("social_media_icon.png")
|
|
click_button "Update"
|
|
end
|
|
|
|
expect(page).to have_css("img[src*='social_media_icon.png']")
|
|
|
|
within("tr#image_social_media_icon") do
|
|
click_button "Delete"
|
|
end
|
|
|
|
expect(page).not_to have_css("img[src*='social_media_icon.png']")
|
|
end
|
|
end
|