db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
22 lines
690 B
Ruby
22 lines
690 B
Ruby
require "rails_helper"
|
|
|
|
describe Verification::Sms do
|
|
it "is valid" do
|
|
sms = build(:verification_sms)
|
|
expect(sms).to be_valid
|
|
end
|
|
|
|
it "validates uniqness of phone" do
|
|
create(:user, confirmed_phone: "699999999")
|
|
sms = Verification::Sms.new(phone: "699999999")
|
|
expect(sms).not_to be_valid
|
|
end
|
|
|
|
it "only allows spaces, numbers and the + sign" do
|
|
expect(build(:verification_sms, phone: "0034 666666666")).to be_valid
|
|
expect(build(:verification_sms, phone: "+34 666666666")).to be_valid
|
|
expect(build(:verification_sms, phone: "hello there")).not_to be_valid
|
|
expect(build(:verification_sms, phone: "555; DROP TABLE USERS")).not_to be_valid
|
|
end
|
|
end
|