db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
57 lines
1.3 KiB
Ruby
57 lines
1.3 KiB
Ruby
shared_examples "map validations" do
|
|
let(:mappable) { build(model_name(described_class)) }
|
|
|
|
describe "validations" do
|
|
before do
|
|
Setting["feature.map"] = true
|
|
end
|
|
|
|
it "is valid with a map location" do
|
|
mappable.map_location = build(:map_location)
|
|
mappable.skip_map = nil
|
|
|
|
expect(mappable).to be_valid
|
|
end
|
|
|
|
it "is valid accepting that the mappable has no map" do
|
|
mappable.skip_map = "1"
|
|
mappable.map_location = nil
|
|
|
|
expect(mappable).to be_valid
|
|
end
|
|
|
|
it "is valid when the feature map is deactivated" do
|
|
Setting["feature.map"] = nil
|
|
|
|
mappable.map_location = nil
|
|
mappable.skip_map = nil
|
|
|
|
expect(mappable).to be_valid
|
|
end
|
|
|
|
it "is not valid without a map location" do
|
|
mappable.map_location = nil
|
|
mappable.skip_map = nil
|
|
|
|
expect(mappable).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without accepting that the mappable has no map" do
|
|
mappable.skip_map = nil
|
|
|
|
expect(mappable).not_to be_valid
|
|
end
|
|
end
|
|
|
|
describe "cache" do
|
|
it "expires cache when the map is updated" do
|
|
map_location = create(:map_location)
|
|
mappable.map_location = map_location
|
|
mappable.save!
|
|
|
|
expect { map_location.update(latitude: 12.34) }
|
|
.to change { mappable.reload.updated_at }
|
|
end
|
|
end
|
|
end
|