11832cc07d
When customizing CONSUL, one of the most common actions is adding a new
field to a form.
This requires modifying the permitted/allowed parameters. However, in
most cases, the method returning these parameters returned an instance
of `ActionController::Parameters`, so adding more parameters to it
wasn't easy.
So customizing the code required copying the method returning those
parameters and adding the new ones. For example:
```
def something_params
params.require(:something).permit(
:one_consul_attribute,
:another_consul_attribute,
:my_custom_attribute
)
end
```
This meant that, if the `something_params` method changed in CONSUL, the
customization of this method had to be updated as well.
So we're extracting the logic returning the parameters to a method which
returns an array. Now this code can be customized without copying the
original method:
```
alias_method :consul_allowed_params, :allowed_params
def allowed_params
consul_allowed_params + [:my_custom_attribute]
end
```
48 lines
1.2 KiB
Ruby
48 lines
1.2 KiB
Ruby
class Admin::SiteCustomization::ImagesController < Admin::SiteCustomization::BaseController
|
|
load_and_authorize_resource :image, class: "SiteCustomization::Image"
|
|
|
|
def index
|
|
@images = SiteCustomization::Image.all_images
|
|
end
|
|
|
|
def update
|
|
if params[:site_customization_image].nil?
|
|
redirect_to admin_site_customization_images_path
|
|
return
|
|
end
|
|
|
|
if @image.update(image_params)
|
|
notice = t("admin.site_customization.images.update.notice")
|
|
redirect_to admin_site_customization_images_path, notice: notice
|
|
else
|
|
flash.now[:error] = t("admin.site_customization.images.update.error")
|
|
|
|
@images = SiteCustomization::Image.all_images
|
|
idx = @images.index { |e| e.name == @image.name }
|
|
@images[idx] = @image
|
|
|
|
render :index
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
if @image.update(image: nil)
|
|
notice = t("admin.site_customization.images.destroy.notice")
|
|
else
|
|
notice = t("admin.site_customization.images.destroy.error")
|
|
end
|
|
|
|
redirect_to admin_site_customization_images_path, notice: notice
|
|
end
|
|
|
|
private
|
|
|
|
def image_params
|
|
params.require(:site_customization_image).permit(allowed_params)
|
|
end
|
|
|
|
def allowed_params
|
|
[:image]
|
|
end
|
|
end
|